Migrate ruby to new importers #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
some of ruby logs. Can you have a look at |
TG1999
reviewed
Sep 22, 2022
TG1999
reviewed
Oct 18, 2022
|
@ziadhany what's the status on this ? |
I will work on it this week. 👍 |
|
@ziadhany invert functionality has been added to univers, please use https://pypi.org/project/univers/30.9.1/ |
|
@ziadhany gentle ping |
ziadhany
force-pushed
the
ruby
branch
2 times, most recently
from
4e90f8d
to
2c50219
Compare
ziadhany
force-pushed
the
ruby
branch
2 times, most recently
from
2fa6915
to
c6091c9
Compare
|
Ruby importer and improver logs : |
ziadhany
force-pushed
the
ruby
branch
4 times, most recently
from
832fb3b
to
2ed17d6
Compare
|
logs : importer--improver-ruby.zip |
ziadhany
force-pushed
the
ruby
branch
2 times, most recently
from
03e0b80
to
469df9f
Compare
|
almost there -- needs one more review |
|
@ziadhany please rebase your PR |
Done |
TG1999
requested changes
Dec 12, 2023
vulnerabilities/importers/ruby.py
Outdated
| record = load_yaml(path) | ||
| class RubyImporter(Importer): | ||
| license_url = "https://github.com/rubysec/ruby-advisory-db/blob/master/LICENSE.txt" | ||
| spdx_license_expression = "unknown" |
There was a problem hiding this comment.
@ziadhany @pombredanne what should be done for this?
There was a problem hiding this comment.
@ziadhany let's get some stats, how much data we can ingest once we filter out the data that is associated with OSVDB ?
There was a problem hiding this comment.
https://scancode-licensedb.aboutcode.org/public-domain-disclaimer.html ,
spdx_license_expression = "LicenseRef-scancode-public-domain-disclaimer"
notice = """
If you submit code or data to the ruby-advisory-db that is copyrighted by
yourself, upon submission you hereby agree to release it into the public
domain.
The data imported from the ruby-advisory-db have been filtered to exclude
any non-public domain data from the data copyrighted by the Open
Source Vulnerability Database (http://osvdb.org).
THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
"""
TG1999
changed the title
ziadhany
force-pushed
the
ruby
branch
2 times, most recently
from
8678d54
to
850c5a7
Compare
TG1999
changed the title
TG1999
approved these changes
Feb 5, 2024
TG1999
reviewed
Feb 5, 2024
Drop cvss_v2 Add ruby importer_name and Rebase Resolve merge conflicts Add advisory_url to ruby importer Add a notice and the spdx_license_expression Resolve merge conflict Add a docstring to get_affected_packages Add a unite test for get_affected_packages function Remove unused variables Fix sorted affected_package_merge Add ruby importer and improver Fix style test Fix test Rewrite affected_packages Ruby initial config Reference: aboutcode-org#796 Clean imported data after import process Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com> Fix sorted affected_package_merge Refactor Ruby importer and improver Add ruby importer and improver Fix style test Fix test Rewrite affected_packages Ruby initial config Reference: aboutcode-org#796 Signed-off-by: ziadhany <ziadhany2016@gmail.com>
|
@ziadhany thanks for your effort and persistence : ) |
TG1999
pushed a commit
to TG1999/vulnerablecode
that referenced
this pull request
Jul 19, 2024
…rg#799) Drop cvss_v2 Add ruby importer_name and Rebase Resolve merge conflicts Add advisory_url to ruby importer Add a notice and the spdx_license_expression Resolve merge conflict Add a docstring to get_affected_packages Add a unite test for get_affected_packages function Remove unused variables Fix sorted affected_package_merge Add ruby importer and improver Fix style test Fix test Rewrite affected_packages Ruby initial config Reference: aboutcode-org#796 Clean imported data after import process Fix sorted affected_package_merge Refactor Ruby importer and improver Add ruby importer and improver Fix style test Fix test Rewrite affected_packages Ruby initial config Reference: aboutcode-org#796 Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference: #796
Signed-off-by: Ziad ziadhany2016@gmail.com