-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for yargs 3.28.0 #7
Comments
@nexdrew I bet we can get the cliui ansi escape tests running without trimming the end of lines. |
@bcoe I will do my best to take a look at the cliui tests tomorrow. Thanks! |
@bcoe I started looking into cliui today. Something going on with left padding when ANSI escape codes are used. I'll get to the bottom of it tomorrow. |
See cliui PR 13. |
@nexdrew I've published a release candidate of yargs with your changes to cliui:
Let me know if this does the trick and I'll get the version promoted to latest. I've also pulled in some parsing fixes I made, and a few other tweaks, the extra set of eyes is much appreciated. |
@bcoe Yes, now that (Note that ANSI output works with |
This version of yargs added better handling of ANSI escape codes, but it appears that this can adversely affect the application of colors and fonts within yargonaut - namely it removes preceding whitespace from rendered fonts (i.e. lines that begin with whitespace have their whitespace trimmed).
Here's an example. Note the first line of "Commands:", "Options:", and "Examples:" is off.
See if there's something yargonaut can do to avoid this.
The text was updated successfully, but these errors were encountered: