Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for yargs 3.28.0 #7

Closed
nexdrew opened this issue Oct 17, 2015 · 6 comments
Closed

Support for yargs 3.28.0 #7

nexdrew opened this issue Oct 17, 2015 · 6 comments

Comments

@nexdrew
Copy link
Owner

nexdrew commented Oct 17, 2015

This version of yargs added better handling of ANSI escape codes, but it appears that this can adversely affect the application of colors and fonts within yargonaut - namely it removes preceding whitespace from rendered fonts (i.e. lines that begin with whitespace have their whitespace trimmed).

Here's an example. Note the first line of "Commands:", "Options:", and "Examples:" is off.
screen shot 2015-10-17 at 12 30 50 am

See if there's something yargonaut can do to avoid this.

@bcoe
Copy link

bcoe commented Oct 18, 2015

@nexdrew I bet we can get the cliui ansi escape tests running without trimming the end of lines.

@nexdrew
Copy link
Owner Author

nexdrew commented Oct 19, 2015

@bcoe I will do my best to take a look at the cliui tests tomorrow. Thanks!

@nexdrew
Copy link
Owner Author

nexdrew commented Oct 20, 2015

@bcoe I started looking into cliui today. Something going on with left padding when ANSI escape codes are used. I'll get to the bottom of it tomorrow.

@nexdrew
Copy link
Owner Author

nexdrew commented Oct 20, 2015

See cliui PR 13.

@bcoe
Copy link

bcoe commented Oct 21, 2015

@nexdrew I've published a release candidate of yargs with your changes to cliui:

npm install yargs@next

Let me know if this does the trick and I'll get the version promoted to latest. I've also pulled in some parsing fixes I made, and a few other tweaks, the extra set of eyes is much appreciated.

@nexdrew
Copy link
Owner Author

nexdrew commented Oct 21, 2015

@bcoe Yes, now that cliui@3.0.3 is being used by yargs, everything looks great! 👍 Thanks, Ben.

(Note that ANSI output works with yargs@3.28.0 and yargs@3.29.0 now, since their cliui semver dependency both resolve to cliui@3.0.3)

Here's the example again, now fixed:
screen shot 2015-10-21 at 9 28 22 am

@nexdrew nexdrew closed this as completed Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants