Remove default binning in Buffy

[gonzaponte]

This line is extremely dangerous as it uses a default value that the user surely is not aware of and probably doesn't understand. This has caused troubles in the past. I believe it doesn't cause them anymore, but it's better to be safe than sorry.

IC/invisible_cities/cities/buffy.py

Line 165 in 86e39c4

return 25 * units.ns, 1 * units.mus

[paolafer]

What do you suggest we do with that? Return None, remove that function and use the exception directly in the code...?

[gonzaponte]

I believe now all nexus files contain the binning, right? If so I would raise an exception if the values are not found.

[paolafer]

I don't know if that's what you mean, but could we simply remove

return 25 * units.ns, 1 * units.mus?
The exception is raised inside the for-loop. I dont' understand how that function works exactly.

[paolafer]

I see that in the current version of the function, if no binnings are found in any of the files, the default values are returned. If we want to change that (sensible), we have to modify the test that deals with empty tables (test_buffy_filters_empty). There's no description of what the test is supposed to ensure, so I'm a bit puzzled about how to change the test.