This repository has been archived by the owner on Jul 17, 2022. It is now read-only.
fix(neo4j): update user bugfix #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # packages/neo4j/src/index.ts
updateUser is returning a user object. Previously it returned object like { 'properties(u): { id: '...' } }`,}
use cleaner notation u{.*} instead of properties(u).
Basic test:
See the update user test. As the value returned by the adapter is used by nextauthjs, I suggest we test here and have drafted an addition for consideration.
2 tasks
balazsorban44
approved these changes
Dec 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasoning 💡
Using the neo4j adapter, I noticed that if I sign in with Facebook, then, with email - it fails.
The reason being that updateUser returned an object like { 'properties(u): { id: '123', name: 'abc' } },}`
This PR fixes that by returning a user object fromupdateUser
In addition I have used shorter notation u{.*} instead of properties(u) throughout all neo4j statements.
And, to catch this bug in future, I have made an edit to basic-tests.js for your consideration.
Checklist 🧢
- [ ] DocumentationAffected issues 🎟
Dupe of PR #348 except for main branch