Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship own filepicker code #1

Closed
ChristophWurst opened this issue Jun 19, 2019 · 5 comments · Fixed by #878
Closed

Ship own filepicker code #1

ChristophWurst opened this issue Jun 19, 2019 · 5 comments · Fixed by #878
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@ChristophWurst
Copy link
Contributor

Right now we just delegate, but ideally this package should be independent

@ChristophWurst ChristophWurst added the enhancement New feature or request label Jun 19, 2019
@ChristophWurst
Copy link
Contributor Author

what typo?

@StCyr
Copy link

StCyr commented Feb 8, 2021

hmm I must have been tired when I wrote this comment.

I think it's because I saw that:

filepicker: function(title, callback, multiselect, mimetypeFilter, modal, type, path, options) {

https://github.com/nextcloud/server/blob/26a20ed13f782418b37c16681a7ad7a0c8e943b6/core/src/OC/dialogs.js#L225

I was investigating why, in the Mail app, selecting multiple attachments from Files was not working...

@ChristophWurst
Copy link
Contributor Author

ah. I think we possible just improved the naming here. the library isn't mean to be an identical drop-in replacement

@susnux
Copy link
Contributor

susnux commented Jul 20, 2023

Planning to do this for the file picker improvments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants