Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CopyMove mode with file-picker #719

Closed
rotdrop opened this issue Dec 6, 2022 · 0 comments · Fixed by #896
Closed

CopyMove mode with file-picker #719

rotdrop opened this issue Dec 6, 2022 · 0 comments · Fixed by #896
Assignees
Milestone

Comments

@rotdrop
Copy link

rotdrop commented Dec 6, 2022

Hi,

I stumbled over the issue that the current implementation does not give access to the user-chosen operation mode (copy vs. move). Or am I wrong? IMHO the current approach

https://github.com/nextcloud/nextcloud-dialogs/blob/e61b9da780e80b02ba412e20375395812cbebc83/lib/filepicker.ts#L40-L45

hides this information which in principle is passed as second argument to the res callback, which however is the callback of the promise. And a promise is resolved with only a single argument. Hence this information is not passed on to the calling code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants