Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generateOcsUrl shouldn't add a trailing '/' to the url #209

Closed
StCyr opened this issue Mar 27, 2021 · 5 comments · Fixed by #210
Closed

generateOcsUrl shouldn't add a trailing '/' to the url #209

StCyr opened this issue Mar 27, 2021 · 5 comments · Fixed by #210

Comments

@ChristophWurst
Copy link
Contributor

IIRC this was the case with the old OC.generateOcsUrland I just copy-pasted the code so it's a drop-in replacement

@StCyr
Copy link
Author

StCyr commented Mar 29, 2021

So, I'll create a PR, shall I?

@ChristophWurst
Copy link
Contributor

you may. I think the reason for the trailing slash was that we always added a path to the generated URL

if we drop the trailing slash then we have to release this as a new major version

cc @nextcloud/javascript

@skjnldsv
Copy link
Contributor

Yes, every app will have to adapt lol

@nickvergessen
Copy link
Contributor

I started work on #194 let's combine the two into a useful major, then apps can touch and improve all their calls in one go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants