-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generateOcsUrl shouldn't add a trailing '/' to the url #209
Comments
IIRC this was the case with the old |
So, I'll create a PR, shall I? |
you may. I think the reason for the trailing slash was that we always added a path to the generated URL if we drop the trailing slash then we have to release this as a new major version cc @nextcloud/javascript |
Yes, every app will have to adapt lol |
I started work on #194 let's combine the two into a useful major, then apps can touch and improve all their calls in one go. |
https://github.com/nextcloud/nextcloud-router/blob/24bc4655c8f88561881970b3b419a16f388a2543/lib/index.ts#L38
None of the examples at https://docs.nextcloud.com/server/latest/developer_manual/client_apis/OCS/ocs-api-overview.html# show a trailing '/'
The text was updated successfully, but these errors were encountered: