-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for OCA API? #125
Comments
I just realized that a similar issue for the docs exists: nextcloud/documentation#894 |
nextcloud/documentation#894 and that's still true in my understanding. OCA isn't any kind of public API. You're not supposed another app's APIs (if any) this way. Anything in |
Hm, I see. The particular methods I was looking at are from the For editor-like apps, also the |
Not yet. cc @skjnldsv for anything Files API related |
Well, we should maybe migrate the EDIT
Maybe even some more? |
But OCP is not an official API either. I don't think moving it from OCA to OCP gets us anywhere. I'd rather have an |
This comment has been minimized.
This comment has been minimized.
I like the sound of this. I'd like us to discuss that a bit more.
I'm guessing you need to share the same context, even if apps import said library independently anyway? You'd still have a global variable somewhere I assume? EDIT: https://github.com/nextcloud/nextcloud-event-bus/blob/631bb6172de8c955adf8f2e9999ca96ad3a17d9f/lib/index.ts#L8 |
For the viewer I suppose there is nothing we need to register globally, do we? The event bus does indeed use a global variable because we have to make sure there is exactly one instance of the bus, because if everyone has their own instance than you can't send events between components/apps :) Yet the global is an implementation detail. Apps do not and should not access any of the globals directly. But that's just how I see it. |
Yes, like sidebar, you have external providers. |
I just faced the problem of missing typings for OCA, so I disagree with:
My use case is the workflow engine, as you are required to register new operators using OCA.WorkflowEngine.registerCheck(Plugin);
// and
OCA.WorkflowEngine.registerOperator(Plugin); So as this belongs to nextcloud server, I think it should be exposed by this typings package or moved to the |
For the development of NextCloud apps typings for the
OCA
API would be useful. As far as I can seenextcloud-typings
currently only has types forOC
. Is this planned? Am I missing something?The text was updated successfully, but these errors were encountered: