Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move away from linkifyjs #1488

Closed
skjnldsv opened this issue Oct 18, 2020 · 3 comments · Fixed by #2275
Closed

Move away from linkifyjs #1488

skjnldsv opened this issue Oct 18, 2020 · 3 comments · Fixed by #2275
Labels
1. to develop Accepted and waiting to be taken care of feature: app-sidebar Related to the app-sidebar component feature: rich-contenteditable Related to the rich-contenteditable components

Comments

@skjnldsv
Copy link
Contributor

Uses jQuery and is quite heavy for a simple string replacement
Let's move to https://bundlephobia.com/result?p=linkify-urls, highly supported and sindresorhus is an awesome dev with great libs! :)

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of feature: app-sidebar Related to the app-sidebar component feature: rich-contenteditable Related to the rich-contenteditable components labels Oct 18, 2020
@dartcafe
Copy link
Contributor

Thanks for this hint. I changed from linkifyjs to linkify-urls@2 for polls. Seems that version 3 does not work in safari as mentioned on the github page.

@juliushaertl
Copy link
Contributor

Uses jQuery and is quite heavy for a simple string replacement

linkifyjs also works fine without jquery, but if linkify-urls is a sane replacement, of course saving those bytes makes sense 👍

https://bundlephobia.com/result?p=linkifyjs@2.1.9
https://bundlephobia.com/result?p=linkify-urls@3.1.1

@raimund-schluessler
Copy link
Contributor

We only use linkifyjs/string and webpack is smart enough to not bundle the whole linkifyjs package. However, with linkifyjs@3, linkify-string moved to its own package, so absolutely no need for linkifyjs anymore.

And linkify-string is even smaller than linkify-urls: https://bundlephobia.com/package/linkify-string@3.0.2

So I think we can close this (at least as soon as #2275 is in).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of feature: app-sidebar Related to the app-sidebar component feature: rich-contenteditable Related to the rich-contenteditable components
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants