Fix sizing of modal container and app settings dialog #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
skjnldsv
reviewed
Nov 16, 2020
skjnldsv
reviewed
Nov 16, 2020
The app settings dialog now correctly fits into the modal container despite its variable size. This fixes issues with the scrollbars that did not appear there. Signed-off-by: Vincent Petry <vincent@nextcloud.com>
PVince81
force-pushed
the
bugfix/noid/fix-modal-container-content-sizing
branch
from
75aecb4 to
c62c3e3
Compare
|
I've replaced all changes with a v-deep clause to set display:flex on modal-container only when using in the AppSettingsDialog. @ma12-co can you confirm that the dialog now looks as originally intended with nextcloud/spreed#4576 with smaller sizes ? |
juliusknorr
approved these changes
Nov 17, 2020
marcoambrosini
approved these changes
Nov 18, 2020
skjnldsv
approved these changes
Nov 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modal container's contents now correctly adjusts to its contents
height, but also the content adjusts to the modal's height when that one
is constrained by the window height.
This fixes scrollbar container issues in some screen resolutions with
the app settings dialog.
See nextcloud/spreed#4576 and reduce the vertical window size to reproduce the issue.
Before the fix:
After the fix: