Do not check l10n comments #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
force-pushed
the
fix/ignore-l10n-comments
branch
5 times, most recently
from
a851d66 to
2207fee
Compare
skjnldsv
requested review from
ChristophWurst,
juliusknorr,
PVince81 and
marcoambrosini
skjnldsv
added
3. to review
skjnldsv
force-pushed
the
fix/ignore-l10n-comments
branch
2 times, most recently
from
6a8811a to
9f79397
Compare
skjnldsv
requested review from
korelstar,
violoncelloCH and
raimund-schluessler
skjnldsv
force-pushed
the
fix/ignore-l10n-comments
branch
from
9f79397 to
a540895
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix/ignore-l10n-comments
branch
from
a540895 to
78e4a0d
Compare
|
/backport to stable2 |
|
The backport to stable2 failed. Please do this backport manually. |
|
hah, I knew it.... |
|
@skjnldsv can you take care (as it was your PR) ? otherwise let me know if I should take over |
|
Ah shit, I pushed to stable2 I thought my branch creation was successful --" |
|
Well, it's in now I suppose 🙄 |
|
ref afe0613 seems there's a conflict marker, can you solve it ? |
|
let me remove the old files yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sure we can survive without them