Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow material-design-icons in AppSidebarTabs #1859

Closed
raimund-schluessler opened this issue Apr 18, 2021 · 3 comments · Fixed by #1939
Closed

Allow material-design-icons in AppSidebarTabs #1859

raimund-schluessler opened this issue Apr 18, 2021 · 3 comments · Fixed by #1939
Assignees
Labels
design Design, UX, interface and interaction design enhancement New feature or request feature: app-sidebar Related to the app-sidebar component

Comments

@raimund-schluessler
Copy link
Contributor

Currently, you can only provide a string which is set as a class. It would be nice to allow material-design-icons as we do it e.g. for Actions.

@raimund-schluessler raimund-schluessler added enhancement New feature or request design Design, UX, interface and interaction design feature: app-sidebar Related to the app-sidebar component labels Apr 18, 2021
@skjnldsv
Copy link
Contributor

Time for the Icon component? 🙈

@raimund-schluessler
Copy link
Contributor Author

Time for the Icon component? 🙈

What should it do?

@skjnldsv
Copy link
Contributor

We discussed it a bit before, but having a component that would translate a string into an icon with dynamic loading & caching would be quite nice.
It would support IDs like

mdi:Menu, app:contacts or mimetype:mp4, and would have the logic to manage and fetch them.

Because our main issue is that lots of our APIs are also in php (like settings) a,d passing an icon-id via string would solve all of it. No more slots, just a nice universal way of dealing with icons.

One issue was the IE compatibility, but now that we have dropped it, it might be good to dive into this and have a webComponent that can be used in pure js too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Design, UX, interface and interaction design enhancement New feature or request feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants