Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not allow empty section id in 6.0+ #2917

Closed
nickvergessen opened this issue Aug 2, 2022 · 0 comments · Fixed by #2923
Closed

Do not allow empty section id in 6.0+ #2917

nickvergessen opened this issue Aug 2, 2022 · 0 comments · Fixed by #2923
Assignees
@nickvergessen
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request feature: app-sidebar Related to the app-sidebar component

Comments

@nickvergessen
Copy link
Contributor

Since this is all dropped in the 5.4/6.0+ follow up where id is non optional, i would move that there (or well it's all being removed anyway)

Originally posted by @nickvergessen in #2855 (comment)
@nickvergessen nickvergessen added the 1. to develop Accepted and waiting to be taken care of label Aug 2, 2022
@nickvergessen nickvergessen self-assigned this Aug 2, 2022
@nickvergessen nickvergessen added feature: app-sidebar Related to the app-sidebar component enhancement New feature or request labels Aug 2, 2022
@nickvergessen nickvergessen changed the title Since this is all dropped in the 5.Do not allow empty section id in 6.0+ Do not allow empty section id in 6.0+ Aug 3, 2022
@nickvergessen nickvergessen mentioned this issue Aug 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nickvergessen nickvergessen

Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request feature: app-sidebar Related to the app-sidebar component
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enforce setting section ids nextcloud-libraries/nextcloud-vue
1 participant
@nickvergessen