Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress tests broken due external changes to server repo #3325

Closed
raimund-schluessler opened this issue Oct 1, 2022 · 1 comment · Fixed by #3401
Closed

Cypress tests broken due external changes to server repo #3325

raimund-schluessler opened this issue Oct 1, 2022 · 1 comment · Fixed by #3401

Comments

@raimund-schluessler
Copy link
Contributor

Probably due to #3139 the visual regression tests now get the server CSS live from the server repo. This randomly breaks the visual regression tests here.

Imho this is not a good idea, since then unrelated changes randomly make the cypress tests fails and can't get merged, see e.g. #3323. Furthermore, we then don't know if it was a change here, or in the server that makes the tests fail.

@skjnldsv @CarlSchwan @vinicius73

@skjnldsv
Copy link
Contributor

Probably due to #3139 the visual regression tests now get the server CSS live from the server repo. This randomly breaks the visual regression tests here.

Imho this is not a good idea, since then unrelated changes randomly make the cypress tests fails and can't get merged, see e.g. #3323. Furthermore, we then don't know if it was a change here, or in the server that makes the tests fail.

@skjnldsv @CarlSchwan @vinicius73

Either way there is a downside.
But I will suggest something else, sure :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants