-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BITV] Enhance Multiselect A11Y #3526
Comments
@michaelnissenbaum when there are potentially many options to pick from in a multiselect dropdown do we need to add pagination like in https://vue-select.org/guide/pagination.html? Would the user need to be able to jump to a specific page i.e. page 5 out of 10 available pages? Or is making the option list filterable by typing sufficient to pass the accessibility audit? |
Which kind of pagination navigation you select/implement is up to you. "all" of them could be implemented in accessible way. If you have already something in mind let's discuss whether it is accessible or not and if not, what must be done. Provide me some screenshots and HTML code and I'd analyse it and provide you my feedback. |
Currently we do not have any pagination but do have filtering Our current implementation is available to test in https://nextcloud-vue-components.netlify.app/#/Components/NcSelect?id=ncselect-1, you may scroll down to the "User select examples" section specifically Feel free to test it out by typing to filter the available options and let us know whether this is sufficient to pass the audit? Or if adding some buttons similar to https://vue-select.org/guide/pagination.html |
I took a look at those examples. What I can say - they are not accessible.
Regarding multi select combobox take a look at this example at http://accessibleculture.org/misc/aria/combobox/combobox.html. At least it works quite well with screen reader. Additionally take a loot at https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/Attributes/aria-multiselectable. The current vue version for multi select does not really support screen readers. It provides incorrect information to the users. |
The implementation without checkboxes could be an accessible one in case proper ARIA roles/attributes are used, text and keyboard focus meet contrast requirements and keyboard support is provided. An example could be found at https://www.telerik.com/kendo-angular-ui/components/dropdowns/multiselect/accessibility/. |
What contrast ratio is required for the focused dropdown option @michaelnissenbaum? |
The contrast ration between focused and unfocussed state should be at least 3:1. Please don't forget that in case that keyboard focus is implemented using background colour change the contrast ration between text and its background has to be at least 4,5:1. |
Transferred "Focus of search suggestions is not clearly visible, needs border instead of background" |
Add aria-multiselectable sagalbot/vue-select#1726Using fork https://github.com/nextcloud-deps/vue-selectFix dropdown not opening after closing sagalbot/vue-select#1742Using fork https://github.com/nextcloud-deps/vue-selectThe text was updated successfully, but these errors were encountered: