Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable7] NcNavigationItem active style is broken #4418

Closed
juliusknorr opened this issue Aug 14, 2023 · 4 comments
Closed

[stable7] NcNavigationItem active style is broken #4418

juliusknorr opened this issue Aug 14, 2023 · 4 comments
Assignees
Labels
3. to review Waiting for reviews bug Something isn't working high High priority

Comments

@juliusknorr
Copy link
Contributor

juliusknorr commented Aug 14, 2023

Screenshot 2023-08-14 at 08 39 54

Seems to happen across multiple apps on 27.1.0-beta.1

2023-08-15 12_17_53-Recent - Nextcloud – Mozilla Firefox

So there is

  • a text styling issue for active elements and
  • a icon sytling issue for hovered expandable items
@juliusknorr juliusknorr added bug Something isn't working 1. to develop Accepted and waiting to be taken care of high High priority labels Aug 14, 2023
@juliusknorr
Copy link
Contributor Author

Screenshot 2023-08-14 at 09 12 58

Strangely I cannot find this rule in stable7, only master but there also with a color-primary-element for the background color: https://github.com/nextcloud-libraries/nextcloud-vue/pull/4155/files#diff-33b93648cb065e0fd6af0c35476aa377d217d43b8506c1ae7b3a0bb643eacc53R798-R800

@juliusknorr
Copy link
Contributor Author

Seems that server stable27 is actually using 8.0.0-beta instead of 7.12.2 as per nextcloud/server#39793

nextcloud@1.0.0 /Users/julius/repos/nextcloud/stable27
├─┬ @nextcloud/calendar-availability-vue@0.6.0-alpha1
│ └── @nextcloud/vue@7.12.2 deduped
├─┬ @nextcloud/dialogs@4.2.0-beta.2 invalid: "^4.0.0-beta.2" from the root project
│ └── @nextcloud/vue@8.0.0-beta.2    <---------------------- HERE
├─┬ @nextcloud/password-confirmation@4.0.4
│ └── @nextcloud/vue@7.12.2 deduped
├─┬ @nextcloud/vue-dashboard@2.0.1
│ └── @nextcloud/vue@3.10.2
├── @nextcloud/vue@7.12.2
└─┬ nextcloud-vue-collections@0.10.0
  └── @nextcloud/vue@3.10.2

@juliusknorr
Copy link
Contributor Author

@susnux Could you maybe check that since it is coming from the dialogs bump?

@susnux
Copy link
Contributor

susnux commented Sep 12, 2023

@susnux susnux closed this as completed Sep 12, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Development

No branches or pull requests

3 participants