Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amq_subjectparams has a different size than subjectparams #503

Closed
juliusknorr opened this issue Oct 5, 2020 · 2 comments · Fixed by #509
Closed

amq_subjectparams has a different size than subjectparams #503

juliusknorr opened this issue Oct 5, 2020 · 2 comments · Fixed by #509
Assignees
Labels

Comments

@juliusknorr
Copy link
Member

The subjectparams table of oc_activity_mq has a size limit of 4000 characters while the subjectparams of oc_activity are a longtext column.

@nickvergessen Is there any reasoning behind that? Wouldn't it make sense to have a longtext for the mq table as well, since otherwise activity entries might not be added to the mq table if the subject params json exceeds 4000 chars.

@juliusknorr juliusknorr added the bug label Oct 5, 2020
@nickvergessen
Copy link
Member

$table->addColumn('subjectparams', 'text', [
'notnull' => true,
]);

It's text saves up to 65k chars. If you have a 4k char you had the app disabled when updating from I think oc 8 to 8.1
We could add a migration to try the conversation again, but it's not happening anymore, so it's plain for people migrating very old instances.

@nickvergessen
Copy link
Member

Oh wait, amq_subjectparams is ...

well yeah no reason for that... needs fixing asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants