Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Think about making update process more stable #1400

Closed
szaimen opened this issue Nov 13, 2022 · 3 comments · Fixed by #1420
Closed

Think about making update process more stable #1400

szaimen opened this issue Nov 13, 2022 · 3 comments · Fixed by #1420
Labels
2. developing Work in progress enhancement New feature or request help wanted Extra attention is needed

Comments

@szaimen
Copy link
Collaborator

szaimen commented Nov 13, 2022

Enabled apps can have an influence on if the update pocess fails. (It is indeed the main source why an update fails).

We should think about making it more stable.

One solution would be disabling all apps before the update, then updating, then enabing them again with the correct group values. If re-enabling fails, dont restore the group values and simply leave it disabled but send a notification in that case. This might break some apps, but is still better than failing the updatee process altogether which would bring down the whole instance. (Obviously only do this for apps in the custom_apps dir).

Maybe also create an update log and store that somewhere permanently.

@szaimen szaimen added 0. Needs triage Pending approval or rejection. This issue is pending approval. enhancement New feature or request help wanted Extra attention is needed labels Nov 13, 2022
@szaimen
Copy link
Collaborator Author

szaimen commented Nov 13, 2022

@Zoey2936 WDYT? :)

@Zoey2936
Copy link
Collaborator

I think this could work and would be a better solution then the current way

@szaimen
Copy link
Collaborator Author

szaimen commented Nov 14, 2022

All right! Will have a look at this then :)

@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Nov 14, 2022
@szaimen szaimen added 2. developing Work in progress and removed 1. to develop Accepted and waiting to be taken care of labels Nov 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2. developing Work in progress enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants