Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker network gateway needs to be a trusted proxy in the config.php #4528

Closed
Zoey2936 opened this issue Apr 10, 2024 · 5 comments · Fixed by #4560
Closed

Docker network gateway needs to be a trusted proxy in the config.php #4528

Zoey2936 opened this issue Apr 10, 2024 · 5 comments · Fixed by #4560
Labels
2. developing Work in progress enhancement New feature or request
Milestone

Comments

@Zoey2936
Copy link
Collaborator

Steps to reproduce

  1. Use AIO in reverse proxy mode (with NPMplus)
  2. trigger failed login
  3. see docker network gateway as IP

How to fix:

  • add IP of docker network gateway to trusted_proxies in the config.php (should maybe be added to the entrypoint.sh/start.sh of the nextcloud container)

Expected behavior

log real ip

Actual behavior

logs IP of docker network gateway

Host OS

Debian 12.5

Nextcloud AIO version

v8.1.0

Current channel

beta

Other valuable info

without IP of the docker gateway and then with it added to the trusted_proxies array in the config.php file
grafik

@Zoey2936 Zoey2936 added 0. Needs triage Pending approval or rejection. This issue is pending approval. bug Something isn't working labels Apr 10, 2024
@Zoey2936
Copy link
Collaborator Author

ip r | grep default | grep -o "[0-9]\+\.[0-9]\+\.[0-9]\+\.1" this command outputs the IP of the gateway

@szaimen
Copy link
Collaborator

szaimen commented Apr 11, 2024

Does #2045 help?

@Zoey2936
Copy link
Collaborator Author

As I wrote whithelisting the gateway IP helps, but I think this IP should be always whithelisted

@szaimen szaimen added enhancement New feature or request and removed bug Something isn't working labels Apr 11, 2024
@Zoey2936
Copy link
Collaborator Author

should I open a PR?

@szaimen
Copy link
Collaborator

szaimen commented Apr 17, 2024

Yes, that would be great, thanks :)

@szaimen szaimen added 2. developing Work in progress and removed 0. Needs triage Pending approval or rejection. This issue is pending approval. labels Apr 18, 2024
@szaimen szaimen added this to the next milestone Apr 18, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2. developing Work in progress enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants