Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting a delay before auto upload / auto upload on-device deletion #2323

Open
ghost opened this issue Mar 9, 2018 · 15 comments · May be fixed by #11278
Open

Allow setting a delay before auto upload / auto upload on-device deletion #2323

ghost opened this issue Mar 9, 2018 · 15 comments · May be fixed by #11278

Comments

@ghost
Copy link

ghost commented Mar 9, 2018

Actual behaviour

-Tell us what happens

Set auto upload to delete after upload. Take a photo. Go to show it to someone in the on-device gallery, and it's gone. Go to edit it on device, it's gone. Go to email/text it, it's gone.

Expected behaviour

-Tell us what should happen

It's very convenient to have photos auto uploaded, and deleting them after successful upload helps manage device space utilization. But the immediacy of the upload/delete causes usage problems.

Ideally, should be able to set a delay between the photo being created and the upload/delete (i.e., file age greater than x minutes). Setting the delay to zero would work as it does now. Setting it to greater than zero would only consider photos/videos that we last modified per the setting.

Steps to reproduce

  1. Take a photo
  2. Open the gallery
  3. Where's the photo?

Environment data

Android version: 8.0

Device model: OnePlus 5

Stock or customized system: Stock

Nextcloud app version: 3.0.3

Nextcloud server version: 13.0.0

@xXSTrikeXx xXSTrikeXx added enhancement needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Mar 10, 2018
@timmersr
Copy link

I would prefer a delay too. The current partial work-around is to set 'Only upload when charging'.

@Bugsbane
Copy link
Member

@timmersr Rather than adding a "me too" comment, try adding a "thumbs up" reaction to the original post. This way the developers dob't get overwhelmed with comments that don't further define the problem/solution, and they can see how many people want the feature, right in a number on the original post.

@Bugsbane
Copy link
Member

By the way, we seem to have quite a few requests for "delay before uploading/deleting" functionality. Just from I quick search, I see:
#1167
#1445
#1803
#1899

...in addition to this issue. The most common usecase between these issues seems to be wanting to conserve space on the device, but still to be able to see and share recently taken photos.

@wawont
Copy link

wawont commented Aug 24, 2018

"seems to be wanting to conserve space on the device, but still to be able to see and share recently taken photos."
+1 Yes!

@ape69
Copy link

ape69 commented Apr 30, 2020

I would like to add another point of view on the topic of adding a customizable delay to the auto upload feature.

When taking some photos with the camera there will be some bad/unsharp pics, from time to time. Personally I delete those pics right away on my phone which saves me sorting and cleanup time later, but with the current nonexisting delay they will get uploaded immediately.

This will force you to do the cleanup of bad photos once again if you work with your Nextcloud photos.

@florianwgnr
Copy link

florianwgnr commented May 12, 2020

I agree with @ape69 At the moment i´m stuck between "upload while charging" and "direct", because the upload starts too late for me when i choose "while charging" and using the direct upload, i get a ton of bad pictures in my nextcloud-folder.

A configurable delay, e.g. "wait 30s or 60s before uploading", whilch can be activated just like the option "only while charging", would be great!

@laquiche-secu
Copy link

+1
A period of 24 hours allows the photos to be printed, before they are uploaded

@only1thor
Copy link

I, want to add my name to the list of users that want this.
would be great for when I just want to snap a photo of a serial number or something just to bring back to my desk and fill it in, then delete the image.
Not every photo needs to be uploaded and eat space, and clutter my drive.

@Russtopia
Copy link

Russtopia commented Jun 17, 2023

I also vote for this as a critical enhancement. My wife is a shutterbug, and is always running out of storage on her phone. Nextcloud has solved the backup problem to get off of Google Photos, but the instant deletion annoys her as she wants to refer to recent photos on her phone to send later that evening, or even a few days later.

If I had spare time, I'd be willing to learn how to build the Android client and do the feature myself, if need be.

I'm just a random interloper, with little to no experience in Kotlin, but it looks to me like one could just add a file age criterion to the call here:

new FilesUploadHelper().uploadNewFiles(user,

... to let it filter what to upload based on file age. It looks like this call passes in all the other upload setting criteria, like whether to do so only on wifi, nameCollisionPolicy, etc.

(Of course, the UI would also need to be written to add the setting for this to the Upload Settings area but that should also be relatively easy for someone familiar with Android app development.)

@sanchosk
Copy link

I would be willing to sponsor this feature - being able to set the delay to, let's say, 30 days would solve a lot of storage issues my daughters have.

@scoopex
Copy link

scoopex commented Dec 15, 2023

I would be willing to sponsor this feature to - i also have daughters with the same problem!

If they have several gigabytes of pictures on their phone, the synchronization tends to become error-prone and at some point the device is just so cluttered, the storage space becomes scarce and it becomes really time-consuming to clean up the device again. As a result, my daughters simply switch Google Images synchronization back on - data sovereignty doesn't matter for them if the device makes problems.

@joshtrichards joshtrichards changed the title Allow setting a delay before auto upload Allow setting a delay before auto upload / auto upload deletion Dec 20, 2023
@joshtrichards joshtrichards changed the title Allow setting a delay before auto upload / auto upload deletion Allow setting a delay before auto upload / auto upload on-device deletion Dec 20, 2023
@uspecies

This comment has been minimized.

@AlexandreMarkus
Copy link

Here is the information about the behavior Google photos is using:

Delete backed-up photos automatically
On Files by Google, you can automatically delete backed-up photos to free up space.

When you turn on Smart Storage, photos backed up in Google Photos are deleted automatically:

If photos are saved for 60 days
If your device’s storage is less than 25%

@DcryptedCA
Copy link

Since space is significantly more on the server side than device side, the delay seems more important to file delete dates (delete older than 3 month, 6 month, 12 month etc) versus delaying file uploads (and then immediate deletion). Both features would be useful, but in the immediate future freeing up space and backup of photos seems to be more important.

@bitifet
Copy link

bitifet commented Jan 28, 2025

@DcryptedCA you're right. But the upload may fail (due to several reasons) and then the file is not removed from the phone.

If you simply remove files older than a given time instead of removing files successfully uploaded, you may end up loosing files whose upload failed unless you implement an additional mechanism to keep track of which files can actually be removed.

...which would be great! But harder to implement than just delaying the deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.