-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple file selection is not removed after deleting files #2463
Comments
@andreasmalta thanks for reporting this! @tobiasKaminsky @tobiasKaminsky could reproduce the issue on latest master. |
I would like to tackle this. Just to make sure that I understand correctly, is the desired effect here, that we leave the selection mode or simply reset the selection count to 0? |
Welcome @jmintb and it would be awesome in you tackle this one. ❤️ The desired behavior would be the Android OS default behavior: leave selection mode |
@AndyScherzinger The selection isn't cleared when selecting "local only", should I make a new PR to adress this? :) |
I'd say so yes, to have a consistent behavior for actions triggered for multi selections |
@AndyScherzinger then I will include it in #2861, as it deals with the same issue. :) |
Sounds good to me 👍 |
Actual behaviour
i'm selecting multiple files and then I delete them. on the screen it still tells me "2 selected"
Expected behaviour
I expect automatic deselection after deleting the files
Steps to reproduce
Environment data
Android version: 8.0.0
Device model: Samsung SM-G950F
Stock or customized system: Stock
Nextcloud app version: 3.1.0
Nextcloud server version: 13.0.1
The text was updated successfully, but these errors were encountered: