Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multiple file selection is not removed after deleting files #2463

Closed
andreasmalta opened this issue Apr 12, 2018 · 7 comments · Fixed by #2856
Closed

multiple file selection is not removed after deleting files #2463

andreasmalta opened this issue Apr 12, 2018 · 7 comments · Fixed by #2856

Comments

@andreasmalta
Copy link

Actual behaviour

i'm selecting multiple files and then I delete them. on the screen it still tells me "2 selected"

Expected behaviour

I expect automatic deselection after deleting the files

Steps to reproduce

  1. upload 2 test files
  2. select both files (multiple selection
  3. select to delete them all
  4. the files are deleted but the selection stays on top of the screen

Environment data

Android version: 8.0.0

Device model: Samsung SM-G950F

Stock or customized system: Stock

Nextcloud app version: 3.1.0

Nextcloud server version: 13.0.1

@AndyScherzinger
Copy link
Member

@andreasmalta thanks for reporting this!

@tobiasKaminsky @tobiasKaminsky could reproduce the issue on latest master.

@jmintb
Copy link
Contributor

jmintb commented Jul 27, 2018

I would like to tackle this.

Just to make sure that I understand correctly, is the desired effect here, that we leave the selection mode or simply reset the selection count to 0?

@AndyScherzinger
Copy link
Member

Welcome @jmintb and it would be awesome in you tackle this one. ❤️

The desired behavior would be the Android OS default behavior: leave selection mode

@jmintb
Copy link
Contributor

jmintb commented Aug 2, 2018

@AndyScherzinger The selection isn't cleared when selecting "local only", should I make a new PR to adress this? :)

@AndyScherzinger
Copy link
Member

I'd say so yes, to have a consistent behavior for actions triggered for multi selections

@jmintb
Copy link
Contributor

jmintb commented Aug 2, 2018

@AndyScherzinger then I will include it in #2861, as it deals with the same issue. :)

@AndyScherzinger
Copy link
Member

Sounds good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants