-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When uploading to external mount without write permissions, file can be deleted from local device under upload. #3375
Comments
This comment has been minimized.
This comment has been minimized.
Pinging @nextcloud/server-triage for feedback 👋 |
@dali99 Looks weird. Is it the same behavior like with read-only shared folders? This would then allow us to know if this is a permission or external storage issue. |
I'm not sure how I would test read-only shared folders, since the app disallows me to upload to them / fails with "you are not permitted to upload to this folder" (without deleting the source file 🎉) Changing the permissions on the external storage did allow me to upload successfully for the record |
Okay - then it seems to be a permission propagation issue. cc @rullzer @icewind1991 |
Like on other folder dav should give the client a proper info if a folder is writable. Then we can simply hide the upload button on it. |
Of course we do not always know. If the user doesn't have write permission on the external storage there is no reliable way for us to check that. Of course the upload should also just fail then. I'll see if I can reproduce this. |
This request did not receive an update in the last 4 weeks. Please take a look again and update the issue with new details, otherwise the issue will be automatically closed in 2 weeks. Thank you! |
Actual behaviour
If you try to upload to a sftp external storage that you can't write to, the file shows up for a split second and is then removed.
If delete from device after upload is on, the file will also be removed from the phone.
Expected behaviour
Upload should fail and not delete the file from the phone.
Steps to reproduce
This might be a nextcloud server thing rather than mobile, since the server probably should fail the upload. But never the less I was surprised that the phone doesn't verify the upload was correct before deleting data.
The text was updated successfully, but these errors were encountered: