Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push notification: show body #3753

Closed
Valdnet opened this issue Mar 14, 2019 · 10 comments
Closed

Push notification: show body #3753

Valdnet opened this issue Mar 14, 2019 · 10 comments

Comments

@Valdnet
Copy link
Contributor

Valdnet commented Mar 14, 2019

Describe the solution you'd like

Is it possible for the notification text under the Android system bar to be displayed in its entirety?

Now is:

obraz

To display all text (no bold font - the screenshot is from the application):

obraz

@nextcloud-android-bot
Copy link
Collaborator

GitMate.io thinks possibly related issues are #559 (Notifications), #2003 (Open notifications view of the correct account), #3646 (Enhance uploads view), #1305 (Upload view: make undone possible), and #3111 (Tapping successful upload notification should open the details view directly).

@tobiasKaminsky
Copy link
Member

The notification is divided into two parts: subject and body.
We only show there the subject, so this should be shown in entire.
Is this true for you?

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 16, 2019

It turns out that this notification has only a subject?
It has no body.
This is the entire notification that he receives:

obraz

@tobiasKaminsky
Copy link
Member

Yes, as far as I know this is intended.
The whole body will be shown if you click on it.

@tobiasKaminsky
Copy link
Member

@nickvergessen can we also provide the body?

@nickvergessen
Copy link
Member

Not in push, because the push notification is limited in size. But IIRC we send the id, so you could get the full notification from the server.

@Valdnet
Copy link
Contributor Author

Valdnet commented Mar 19, 2019

Yes, as far as I know this is intended.

Yes.

The whole body will be shown if you click on it.

Yes I know about it 😉
The problem is just that you have to click. There is no clear information at first.

@tobiasKaminsky
Copy link
Member

But IIRC we send the id, so you could get the full notification from the server.

This is true. I can get it and then display the body.

@tobiasKaminsky tobiasKaminsky changed the title View notifications Push notification: show body Mar 19, 2019
@developerfromjokela
Copy link

@nickvergessen What if you put notification ID into the push notification, and fetch notification details from the server? So it will cost less data, and all its content will be loaded on backend. Seems like a good idea. 😀

@tobiasKaminsky
Copy link
Member

In fact we are doing this already.
I implemented it on 18.02.19 and totally forgot about this ticket:

New vs old:
2019-04-10-111354 2019-04-10-111713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants