Uploading a picture twice fails

[gitbensons]

Actual behaviour

• After sucessfully uploading a picture from the camera to a folder, when ever I try to upload the same picture again to another folder it fails with "Hochladen fehlgeschlagen"

Expected behaviour

• Upload should succeed

Steps to reproduce

1. Create folder "Folder1"
2. Open "Folder1" and upload a camera picture eg. "Picture1", upload succeeds
3. Create another folder inside "Folder1", name it "Folder2"
4. Open "Folder2" and try to upload camera picture "Picture1"
5. Upload fails

Environment data

Android version: 6.0.1

Device model: Nexus 5x

Stock or customized system: CyanogenMod 13.0-20161222

Nextcloud app version: 1.4.0

Nextcloud server version: 11

[AndyScherzinger]

Could reproduce it, thanks @gitbensons

Other scenario, have auto upload activated, take a picture have it uploaded by the auto upload and then afterwards manually upload it to a (different) folder. Will also directly fail.

[tobiasKaminsky]

Is there an error message?

[AndyScherzinger]

not in the UI, I didn't check this issue with ADB connected :(

Well, the Upload view say error I think, but that's it.

[AndyScherzinger]

@tobiasKaminsky only thing I see in the log file:

01-30 19:14:58.430 2949-2985/com.nextcloud.client D/ExistenceCheckRemoteOperation: Existence check for http://myserver/remote.php/webdav/Folder1/IMG_20160917_104116.jpg targeting for  existence finished with HTTP status 404(FAIL)
01-30 19:14:58.438 2949-2985/com.nextcloud.client V/UploadsStorageManager: Updating /storage/emulated/0/DCIM/Camera/IMG_20160917_104116.jpg with status:UPLOAD_IN_PROGRESS and result:UNKNOWN (old:/storage/emulated/0/DCIM/Camera/IMG_20160917_104116.jpg status:UPLOAD_IN_PROGRESS result:-1)
01-30 19:14:58.440 2949-2985/com.nextcloud.client V/UploadsStorageManager: Updating /storage/emulated/0/DCIM/Camera/IMG_20160917_104116.jpg with status=UPLOAD_IN_PROGRESS
01-30 19:14:58.462 2949-2985/com.nextcloud.client D/UploadsStorageManager: updateUpload returns with: 1 for file: /storage/emulated/0/DCIM/Camera/IMG_20160917_104116.jpg
01-30 19:14:58.463 2949-2985/com.nextcloud.client D/UploadsStorageManager: notifyObserversNow
01-30 19:14:58.469 2949-2985/com.nextcloud.client E/UploadFileOperation: Upload of /storage/emulated/0/DCIM/Camera/IMG_20160917_104116.jpg to /Folder1/IMG_20160917_104116.jpg: Operation finished with HTTP status code -1 (fail)
01-30 19:14:58.471 2949-2985/com.nextcloud.client D/UploadsStorageManager: updateDataseUploadResult uploadResult: com.owncloud.android.lib.common.operations.RemoteOperationResult@824503e upload: com.owncloud.android.operations.UploadFileOperation@5dd3e9f
01-30 19:14:58.476 2949-2985/com.nextcloud.client V/UploadsStorageManager: Updating /storage/emulated/0/DCIM/Camera/IMG_20160917_104116.jpg with status:UPLOAD_FAILED and result:UNKNOWN (old:/storage/emulated/0/DCIM/Camera/IMG_20160917_104116.jpg status:UPLOAD_IN_PROGRESS result:-1)
01-30 19:14:58.477 2949-2985/com.nextcloud.client V/UploadsStorageManager: Updating /storage/emulated/0/DCIM/Camera/IMG_20160917_104116.jpg with status=UPLOAD_FAILED

Weird thing, I can even upload a file in one folder, then delete it and then try to upload it again.... It'll fail (!)

[AndyScherzinger]

Also calling @mario to the rescue. 🚒

[tobiasKaminsky]

I used app with latest master and I cannot reproduce it on NC11 or NC-master...

[tobiasKaminsky]

Now tested it also with the 1.4.0 as thread starter...
Maybe it depends on file size? I used a rather small (40kb) "test" image.

[tobiasKaminsky]

Indeed, it happens to me if I upload a much larger (4mb) file.

[tobiasKaminsky]

okay. :/
I now that it is my fault, I have implemented #159 in a not correct way.
I will fix it tomorrow.

[mario]

This should work in beta:

https://github.com/nextcloud/android/raw/beta/apks/latest.apk

[tobiasKaminsky]

As this is merged in #nextcloud/android-library/33 I close this issue.