Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PushNotification integration with Deck Android app will cause issues when targetSdk = 30 or higher #7194

Closed
stefan-niedermann opened this issue Nov 1, 2020 · 6 comments · Fixed by #7312

Comments

@stefan-niedermann
Copy link
Member

Similar to this reported issue in the SSO library i am pretty sure, that we will get an issue regarding the PushNotification integration with the Deck Android app as soon as the targetSdk in your build.gradle file will be raised to 30 or higher.

The Nextcloud Files app will then no longer be able to detect whether the Deck Android app is installed or not. As a solution one needs to extend the Nextcloud Files apps AndroidManifest.xml and add <queries> entries, but i am not entirely sure yet how this has to be done.

Resources:

@tobiasKaminsky
Copy link
Member

tobiasKaminsky commented Nov 12, 2020

<manifest package="com.example.game">
    <queries>
        <package android:name="it.niedermann.nextcloud.deck" />
    </queries>
    ...
</manifest>

Might do it…

@stefan-niedermann
Copy link
Member Author

If this works, we would need to add the package ids for the Play Store and the Dev versions, too. (They already are in the integration class, just copy & paste)

@tobiasKaminsky
Copy link
Member

a bit unrelated, or does the "force" to app bundle (which is only for new apps) affects the query part or our SSO part?

@stefan-niedermann
Copy link
Member Author

From November 2021, updates to existing apps will be required to target API level 30 or above

Also updates of existing apps will need the new API level. So if you publish a new version in November 2021, this issue has to be solved or otherwise the Deck integration will be broken.

Basically this is our due date 😄

@AndyScherzinger
Copy link
Member

the "force" to app bundle (which is only for new apps) affects

Nov 2021 this is afaik also true for existing, updated ones. Which leads to another issue: upload bundle and signing happens on gplay side (so you will have to upload the key(s) for the apps...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants