Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load avatars via the new standard API #779

Open
AndyScherzinger opened this issue Mar 26, 2017 · 4 comments
Open

Load avatars via the new standard API #779

AndyScherzinger opened this issue Mar 26, 2017 · 4 comments

Comments

@AndyScherzinger
Copy link
Member

At this moment we load avatars via a private API/URL. nextcloud/server#4062 introduces a public webdav API to load avatars including some meta information. SO I'd say we should move to this API as soon as it becomes available while we still need to keep the "old way" for a while to support older Server versions of Nextcloud and also support avatars a little longer for oC which doesn't have this API (I Guess).

@AndyScherzinger AndyScherzinger added enhancement low needs info Waiting for info from user(s). Issues with this label will auto-stale. labels Mar 26, 2017
@tobiasKaminsky
Copy link
Member

Additionally to this all avatar loading must be non blocking. I had sometimes large delays when a server instance was not accessible.
This should be done in the library, or?

@AndyScherzinger
Copy link
Member Author

AndyScherzinger commented Apr 3, 2017

The loading should be done via the library yes, while the non blocking part might be done within the app or we must implement it in a way that all this is covered within lib code with weak references etc etc.

@tobiasKaminsky
Copy link
Member

We can now also rely for >=NC13 that we always have an avatar: nextcloud/server#6876

@AndyScherzinger
Copy link
Member Author

Nice! 🎉

@joshtrichards joshtrichards removed the needs info Waiting for info from user(s). Issues with this label will auto-stale. label Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants