Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a warning when editing invitations #3886

Open
st3iny opened this issue Jan 14, 2022 · 4 comments
Open

Show a warning when editing invitations #3886

st3iny opened this issue Jan 14, 2022 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Editor

Comments

@st3iny
Copy link
Member

st3iny commented Jan 14, 2022

Followup to #3885

Is your feature request related to a problem? Please describe.
After merging the mentioned PR, users will be able to edit invitations again. Those changes will never be propagated to the real event but it might confuse users.

Describe the solution you'd like
Show a warning in the editor that changes only affect your local version of the event/invitation. Only your participation status will be propagated.

Describe alternatives you've considered

Additional context
None

@st3iny st3iny added 1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Editor labels Jan 14, 2022
@Bolli84
Copy link

Bolli84 commented Jan 19, 2022

@st3iny during reverting it, I recognized the following flaws:

  1. The change of calendars only is working in the simple editor, not the sidebar editor
  2. The format highlighting (URL now clickable) is not working anymore

@st3iny
Copy link
Member Author

st3iny commented Jan 21, 2022

  1. The change of calendars only is working in the simple editor, not the sidebar editor

Could you be a bit more specific about this issue? Is this related to #3898?

  1. The format highlighting (URL now clickable) is not working anymore

This is working as intended. The url formatter only applies to read only events. After the revert, invitations are not read only anymore so the links can't be clicked anymore.

@ChristophWurst
Copy link
Member

Shall we continue in #947?

@Bolli84
Copy link

Bolli84 commented Jan 27, 2022

@st3iny
1: in the sidebar, the bespoken event is not editable, in the Simple editor, it is editable (changing calendar).
2: If the formatting is intended seems very weird, however the link is not clickable. not in simple editor, nor in sidebar.

The #3898 issue is also applied here. I only can change the calendar once, then it is not possible anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of design Related to design, interface, interaction design, UX, etc. enhancement New feature request Feature: Editor
Projects
None yet
Development

No branches or pull requests

3 participants