Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix coverage reports #20

Open
georgehrke opened this issue Oct 6, 2018 · 0 comments
Open

fix coverage reports #20

georgehrke opened this issue Oct 6, 2018 · 0 comments
Labels
medium Medium priority

Comments

@georgehrke
Copy link
Member

Coverage reports are not generated correctly.

Fixing

cdav-library/karma.conf.js

Line 12 in 9582bee

preprocessors: { 'js/**/*.js': ['coverage'] },
to say preprocessors: { 'src/**/*.js': ['coverage'] }, instead of preprocessors: { 'js/**/*.js': ['coverage'] }, breaks all unit tests and throws many "unexpected token: numeric literal".

Most likely istanbul / karma-coverage don't support ES6 modules fully natively yet. (without webpack).
@georgehrke georgehrke added the medium Medium priority label Oct 6, 2018
@georgehrke georgehrke changed the title fix coverage support fix coverage reports Oct 6, 2018
@georgehrke georgehrke modified the milestone: 0.0.3 Jan 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
medium Medium priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@georgehrke