We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global_namespace_import
With configuration ['import_classes' => false, 'import_constants' => false, 'import_functions' => false]: https://cs.symfony.com/doc/rules/import/global_namespace_import.html#example-3
['import_classes' => false, 'import_constants' => false, 'import_functions' => false]
Main benefit for me would be exceptions, as it is a directly clear that a docblock like
/** * @throws Exception */
refers to \OCP\DB\Exception and not \Exception. It would also safe some lines in the imports making them a bit more readable.
\OCP\DB\Exception
\Exception
We could also switch it around, but I think we should settle on some configuration for this rule to have it the same everywhere.
The text was updated successfully, but these errors were encountered:
I agree that for global classes it's better readable/understandable if they are fully qualified inline
Sorry, something went wrong.
I am fine either way
No branches or pull requests
With configuration
['import_classes' => false, 'import_constants' => false, 'import_functions' => false]
: https://cs.symfony.com/doc/rules/import/global_namespace_import.html#example-3Main benefit for me would be exceptions, as it is a directly clear that a docblock like
refers to
\OCP\DB\Exception
and not\Exception
.It would also safe some lines in the imports making them a bit more readable.
We could also switch it around, but I think we should settle on some configuration for this rule to have it the same everywhere.
The text was updated successfully, but these errors were encountered: