Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto fix generates broken code #38

Open
nickvergessen opened this issue Oct 16, 2024 · 0 comments
Open

Auto fix generates broken code #38

nickvergessen opened this issue Oct 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@nickvergessen
Copy link
Member

Deps say the lib supports PHP 7.3+
https://github.com/nextcloud/coding-standard/blob/master/composer.json#L6

But the rule for trailing commas on argument lists is 8.0 and creates a parsing error in 7.3 and 7.4

Either the rules needs to be done conditionally or we need to bump the requirement.

@nickvergessen nickvergessen added the bug Something isn't working label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant