Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search page content when using the page filter in the left navigation #1094

Closed
juliusknorr opened this issue Jan 26, 2024 · 2 comments · Fixed by #1240
Closed

Search page content when using the page filter in the left navigation #1094

juliusknorr opened this issue Jan 26, 2024 · 2 comments · Fixed by #1240
Assignees
Labels
enhancement New feature or request 🍂 2024-Autumn

Comments

@juliusknorr
Copy link
Member

Is your feature request related to a problem? Please describe.
This came up in design discussions with @marcoambrosini

We should think about providing page content search results when filtering in the page list of the left navigation.

Describe the solution you'd like
My initial suggestion would be to still list page title matches first by filtering the page list (as it currently works) but provide content matches in a second list below.

Describe alternatives you've considered
None so far

Additional context
This is also how the search in the Talk mobile app works for example, though I don't think we have a similar pattern yet on the web anywhere.

@juliusknorr juliusknorr added the enhancement New feature or request label Jan 26, 2024
@juliusknorr juliusknorr moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Apr 4, 2024
@juliusknorr juliusknorr moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Apr 4, 2024
@grnd-alt grnd-alt moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Apr 26, 2024
@grnd-alt grnd-alt linked a pull request Apr 29, 2024 that will close this issue
4 tasks
@grnd-alt grnd-alt moved this from 🏗️ In progress to 👀 In review in 📝 Office team Apr 29, 2024
@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team May 2, 2024
@alexanderdd
Copy link

alexanderdd commented May 6, 2024

Also it would be great to then highlight the search term when you go to the page, as it is done in https://docs.nextcloud.com/server/latest/user_manual/en/ (which runs read the docs?)

But I think this also needs a higher-level discussion: There is the unified search in the top right, which is supposed to be THE way to find anything (right?). Afaik it already searches in collectives page contents. Then we don't need the same functionality in two places, right? But then how can users easily discover that the left search bar is just a page title filter, and the real search in in the top right?
Don't want to hijack this thread. If this discussion is already ongoing somewhere, please post a link.

And maybe related: nextcloud/office#13

@juliusknorr
Copy link
Member Author

juliusknorr commented May 7, 2024

Thanks for your feedback @alexanderdd

Also it would be great to then highlight the search term when you go to the page, as it is done in docs.nextcloud.com/server/latest/user_manual/en (which runs read the docs?)

Yes, though this is a separate issue. We are looking into providing search/highlight functionality in the text app which we first need to be able to use this to highlight results within Collectives then. #648

But I think this also needs a higher-level discussion: There is the unified search in the top right, which is supposed to be THE way to find anything (right?). Afaik it already searches in collectives page contents. Then we don't need the same functionality in two places, right? But then how can users easily discover that the left search bar is just a page title filter, and the real search in in the top right?

While we already have the unified search it has quite a few design issues nextcloud/server#24056 especially when it comes to providing quick access within the current visible app context. When discussing this in the past with the design team we came to the conclusion that local filtering also makes sense separately. I don't see why having the unified search would contradict with showing useful results also when performing local filtering in the current collective.

@github-project-automation github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Office team Jun 11, 2024
@github-project-automation github-project-automation bot moved this from 🏗️ At engineering to 🎉 Done in 🖍 Design team Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request 🍂 2024-Autumn
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants