Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for public shares of pages #515

Closed
42ske opened this issue Jan 23, 2023 · 5 comments · Fixed by #1041
Closed

Add support for public shares of pages #515

42ske opened this issue Jan 23, 2023 · 5 comments · Fixed by #1041

Comments

@42ske
Copy link

42ske commented Jan 23, 2023

Is your feature request related to a problem? Please describe.
If you use collectives as cooperative knowledge base of your group/organization it’s a matter of time when the first member wants to share contents with non-members. This is easily possible at the level of collectives. For pages you can manage this a bit complicated via the files-app.

Describe the solution you'd like
I want to be able to:

  1. create a public link for pages according to the function of public links for entire collectives.
  2. There should be an option if this link should also include all supages of a page or not.
  3. The already existing sharing setting in the collectives’ settings should have an effect on the page links of course.

Describe alternatives you've considered
A detour is to share page via the files app, which is not very intuitive.

Additional context
Add any other context or screenshots about the feature request here.

@42ske 42ske added the enhancement New feature or request label Jan 23, 2023
@mejo- mejo- changed the title Enable public links directly from within collectives’ pages Add support for public shares of pages Feb 14, 2023
@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Feb 20, 2023

Is there really a need for being able to share a page without its subpages?
I think it would be fine to only have a way to share both together. One could still fallback to sharing the single page file via files.

  1. The already existing sharing setting in the collectives’ settings should have an effect on the page links of course.

The only option i can think of right now is read-only vs. editable shares. I think they should be independent so i can share the entire collective as read only and a page with its subpages as editable - or the other way around. These links may go to different audiences anyway.

@42ske
Copy link
Author

42ske commented Mar 2, 2023

Is there really a need for being able to share a page without its subpages? I think it would be fine to only have a way to share both together. One could still fallback to sharing the single page file via files.

Being able to share a page with its subpages would be a very useful feature of course. There would be lot of scenarios where this would be enough. But I can imagine, there are also other scenarios in which a seperate possibility would be great.

And yes you are right that you can use the files app for that, but I know for lot of users this ist not very intuitive (I handle it this way).

  1. The already existing sharing setting in the collectives’ settings should have an effect on the page links of course.

The only option i can think of right now is read-only vs. editable shares. I think they should be independent so i can share the entire collective as read only and a page with its subpages as editable - or the other way around. These links may go to different audiences anyway.

Yes, you are absolutely correct with this.

@gbertolottiKS
Copy link

+1 on this. It would be very useful.

Thanks

@hansimausisteffiwurstbrot

to whom it may concern: If we can support this feature with some financial means let us know. :)

@max-nextcloud
Copy link
Collaborator

max-nextcloud commented Oct 11, 2023

Ideas for implementation:

  • provide a share tab in the page sidebar for sharing that particular page and its subpages.
  • don't allow sharing a page without subpages.
  • extend the collectives_shares database with a page_id field.
  • hide the share tab for the landing page => share the collective instead.
  • limit fetch pages to page and subpages
  • In the public share user interface:
    • prevent moving pages in ui and api
    • prevent deleting pages in ui and api
    • don't fetch trash pages, hide the trash, block the trash api

@mejo- mejo- moved this from 🧭 Planning evaluation (don't pick) to 📄 To do (~10 entries) in 📝 Office team Oct 12, 2023
@mejo- mejo- mentioned this issue Dec 13, 2023
35 tasks
@mejo- mejo- moved this from 📄 To do (~10 entries) to 🏗️ In progress in 📝 Office team Dec 18, 2023
@mejo- mejo- self-assigned this Dec 18, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📝 Office team Dec 20, 2023
@jancborchardt jancborchardt moved this to 🎉 Done in 🖍 Design team Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants