Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use package.json version instead of info.xml #1010

Merged
merged 1 commit into from
Mar 22, 2019
Merged

Use package.json version instead of info.xml #1010

merged 1 commit into from
Mar 22, 2019

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 22, 2019

Fix #995

Test release: contacts.tar.gz

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug Something isn't working 3. to review Waiting for reviews high High priority labels Mar 22, 2019
@skjnldsv skjnldsv added this to the next milestone Mar 22, 2019
@skjnldsv skjnldsv self-assigned this Mar 22, 2019
@codecov
Copy link

codecov bot commented Mar 22, 2019

Codecov Report

Merging #1010 into master will increase coverage by 4.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1010      +/-   ##
=========================================
+ Coverage   55.88%     60%   +4.11%     
=========================================
  Files           4       4              
  Lines          68      60       -8     
=========================================
- Hits           38      36       -2     
+ Misses         30      24       -6
Impacted Files Coverage Δ
lib/Controller/PageController.php 83.33% <0%> (+33.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad7b7df...8d7855b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working high High priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant