Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Company Saved as Contact Name (webdav iOS) #1083

Closed
sknsean opened this issue May 1, 2019 · 13 comments
Closed

Company Saved as Contact Name (webdav iOS) #1083

sknsean opened this issue May 1, 2019 · 13 comments
Labels
bug Something isn't working

Comments

@sknsean
Copy link

sknsean commented May 1, 2019

Describe the bug

When adding a company name to a contact the name is removed and the company is displayed.

To Reproduce
Create a new contact, add company name

Expected behavior
The First and Last should be kept and the company name added as a company name.

Actual behavior
Only the company name is synced

Screenshots
nextcloudcontacts
IMG_0835


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@sknsean
Copy link
Author

sknsean commented May 1, 2019

possibly related to #986 #165 #848

@sknsean
Copy link
Author

sknsean commented May 1, 2019

vcf from contact created in nextcloud:
BEGIN:VCARD
VERSION:3.0
PRODID:-//Sabre//Sabre VObject 4.1.6//EN
UID:701932cf-5f16-4114-8894-ca9701b3838f
REV;VALUE=DATE-AND-OR-TIME:20190501T113643Z
FN:Jens Jensen
ADR;TYPE=HOME:;;;;;;
EMAIL;TYPE=HOME:jens@jensenc.dk
TEL;TYPE="HOME,VOICE":+4580808080
ORG:Consultantcompany
END:VCARD

@skjnldsv
Copy link
Member

skjnldsv commented May 1, 2019

Hello :)
If I understand correctly, you expect to have Jens Jensen displayed on your iOS device?

@skjnldsv skjnldsv added 0. to triage Pending approval or rejection. This issue is pending approval. bug Something isn't working needs info Not enough information provided labels May 1, 2019
@sknsean
Copy link
Author

sknsean commented May 1, 2019

Yes exactly :-)
There is also an extra " before the "HOME" number.
IMG_0836
As seen here the First and Last name is empty

@skjnldsv
Copy link
Member

skjnldsv commented May 1, 2019

This is an iOS issue then. If you look at your contact vcard, you'll see that the FN property is still set with the proper data. iOS have just decided to display the ORG instead.

First name and Last name are empty because you never set it on nextcloud. You need to add a detailed name property (N) on nextcloud. FN is the display name, and your device seems to ignore it if ORG is set 😉. But I still don't know if iOS will prefer displaying the ORG or the N property then. Please try and report back :)

For the " in front of home, this is also an iOS issue unfortunately. This is correct, a vcard can have a TYPE="home,voice" data set, but iOS is somehow not properly displaying it 🤔
Can you try

@sknsean
Copy link
Author

sknsean commented May 1, 2019

Vcf when Contact is created from iOS
BEGIN:VCARD
VERSION:3.0
PRODID:-//Apple Inc.//iOS 12.2//EN
N:Nielsen;Niels;;;
FN:Niels Nielsen
ORG:FishingCompany;
EMAIL;type=INTERNET;type=HOME;type=pref:niels@fish.eu
TEL;type=HOME;type=VOICE;type=pref:44 74 74 74
REV:2019-05-01T14:08:13Z
UID:BE3309BE-0E6B-4F17-BD4B-F1E2DBBDA6F1
END:VCARD

Hehe, it’s not easy to fix things in iOS ;-).
Will try to set first and last name, later and report back

@skjnldsv
Copy link
Member

skjnldsv commented May 1, 2019

Vcf when Contact is created from iOS

and it's properly displayed in iOS?
If so then it's fine, but you should know that you will need to use the detailed name property and not only the display name one :)

@sknsean
Copy link
Author

sknsean commented May 2, 2019

Yes it's properly displayed.
It's also properly displayed when setting first and last name in nextcloud.
Would it be difficult to change (aka. more difficult than to convince Apple to comply with the standard):
TEL;TYPE="HOME,VOICE": to TEL;type=HOME;type=VOICE:

@skjnldsv
Copy link
Member

Issue is that if we do so, we might also lose compatibility with other softwares/platforms :)
Also I think the library we use for that is bugged and does not support it properly.
kewisch/ical.js#343

@ghost
Copy link

ghost commented Jul 23, 2019

#1107 for the VCF format.

I've brought up the company name issue before. Didn't end well.

@ghost
Copy link

ghost commented Aug 22, 2019

This issue has been automatically marked as stale because it has not had recent activity and seems to be missing some essential information. It will be closed if no further activity occurs. Thank you for your contributions.

@ghost ghost added the stale label Aug 22, 2019
@ghost
Copy link

ghost commented Aug 22, 2019

Not stale. No missing information. Fix needed.

#1107 for the VCF format.

@ghost ghost removed the stale label Aug 22, 2019
@skjnldsv skjnldsv removed the needs info Not enough information provided label Aug 23, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Aug 23, 2019

Sorry, forgot to remove the needs info label :)
Though closing since for multiple types we have this: #942
And for the various vcf formats #1107

And regarding the FN/N misconception, well, that's how vcards works 🤷‍♂️ :)

@skjnldsv skjnldsv removed the 0. to triage Pending approval or rejection. This issue is pending approval. label Sep 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants