Some contact pictures aren't loading in the contacts list. #1140
Labels
Comments
Here, this is the issue. Are you using nginx or apache? |
|
I'm using apache2 as Nextcloud Server and nginx as a reverse proxy. Thank you for this nearly instant response! I'm quite impressed right now ^^ |
|
Could you share both of your configs? |
|
Sure! Apache Config (Nextcloud Host): Ngnix (Reverse Proxy): |
|
Hum, I don't see anything that could be an issue here. The request to a contact with ?photo at the end of the url is supposed to return the photo. With a 200 http code. On the network tab, could you screenshot or copy the request header of one of the ?photo requests? (you selected the xhr filter, it should be in img or all) |
|
And also the response header (and if any, the response content) |
|
For the logs, I scrolled down a bit more until a Contact with proper picture loading appeared. This one doesn't load: This one loads (I see it in Nextcloud): |
|
Hum, so the contacts list doesn't display them at all? |
|
Like I wrote in the description, only a few are failing. It seems only the ones, where I set the profile picture on my android device with the AOSP Contacts App fail to load. I used photos from my phone camera. The ones, that load, were imported some time ago from a vcf file and therefore are very low res / size. They were imported from my phone and then synced via DAVx5 as well. |
🙈
That explain the very small sizes. Could you share the broken contact? You can edit the data in it (and remove the photo property lines EXCEPT the first one so I can see how it is formated) |
|
Sure! What do you mean, by "share" Posting a vcf file or a nextcloud share? |
|
Post the vcf here :) (as text, you cannot attach it) |
|
Hum, the picture is loading fine for me here 🤔 EDIT: hu, where did your comment go? ^^ |
|
I created a new Contact on my phone, set a picture from my photos and synced it with nextcloud. So it does not load properly. The attached vcf file is downloaded from contacts in nextcloud. Edit: sorry for the mess with the comment. Messing around with formatting.. It's my first issue i reported on github.. |
|
AHah don't worry. |
After deleting the contact and importing it in nextcloud again from the vcf file it works fine for me as well.. |
|
@akoyaxd hum, it might have been a badly cached property in the db? |
No, it was returning 200. But without content..
Well it is not really fixed.. The issue remains to all other contacts, that got their picture set in the android app.. |
Ah that is interesting! |
|
I just stumbled across this thread. Is it possible that the import function "fixes" or "rescales" the image, so it is displayed properly, but if you just sync from your phone the image is taken as-is, which results in the problem? |
|
@mburnicki what do you mean rescale? |
I'm using a jpeg
This is an interesting idea.. the vcf file indeed changes during the import. This is the vcf file after syncing it from my phone: And this is the vcf file after deleting the contact in nextcloud, importing the contact via nextcloud and the redownloading it again. |
|
EDIT: ah no, it did not. |
|
@akoyaxd what happen if you empty the oc_cards_properties table (it won't cause any harm, but you can backup if you prefer, data are fully stored into oc_cards) Does the behaviour change? |
|
AH! I can reproduce! Differences are: |
@skjnldsv It was just a thought that the kind of processing of the submitted contact and photo may be different if you import a VCF via the contacts app and push it into the database, or if some carddav client pushes it directly to the database. I'm actually still stuck on an older nextcloud and contact version. |
skjnldsv
added
1. to develop
|
Ah ok! :) @akoyaxd Found the issue. |
Nice to hear, that the issue is found. So I don't have to fiddle with the oc_tables anymore? ^^ As someone with VERY limited to none programming skills, is there something i can do to help to fix it? Btw. Is there a way to make this vcf file content "collapsible" to make it easier to scroll through this issue? |
|
Yes, you can use a html detail to create a collapsible content. Nothing more to do unless you know javascript :) |
|
okay, thank you for your time! |
What is the issue? Is there a fix available or in progress? |
|
Nothing started yet @jangop :) |
|
Is it because in Line 115 the |
|
@jangop nope, this is because we encode vcard3 with tthe vcard4 format! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Contact pictures where the profile picture was set in the android App e.g. from a photo and synced via davx5, are not shown initially in the contacts list. Only after clicking on them.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The Contact picture is shown in the list of contacts.
Actual behavior
The Contact picture is only shown, if you open the contact, by clicking on it.
Also See: #477
Server configuration
Operating system: Ubuntu 18.04
Web server: Apache, Nginx (Reverse Proxy)
Database: MariaDB
PHP version: 7.2
Nextcloud version: 16.0.1
Contacts version: 3.1.3
Updated from an older Nextcloud or fresh install: Updated
Client configuration
Browser:
Chromium
Firefox
Operating system:
Android
CardDAV-clients:
DAVx5
Logs
Browser log
Console:
Network:
The text was updated successfully, but these errors were encountered: