Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location field tells me to enter an URL. #1324

Open
RobertZenz opened this issue Nov 1, 2019 · 4 comments
Open

Location field tells me to enter an URL. #1324

RobertZenz opened this issue Nov 1, 2019 · 4 comments
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working

Comments

@RobertZenz
Copy link

RobertZenz commented Nov 1, 2019

The new Location field is marked red and tells me to enter an URL, even when it is pre-filled with coordinates.

  1. Open a contact.
  2. Add the Location field.
  3. It's red already, even though it was just pre-filled with the default.

Additionally, the default value uses a semicolon ; to separate the coordinates, but after saving and loading it has changed to a comma ,.

Server configuration

Operating system: CentOS 7

Web server: lighttpd

Database: SQLite

PHP version: 7.2

Nextcloud version: 16.0.4

Contacts version: 3.1.6

@RobertZenz RobertZenz added 0. Needs triage bug Something isn't working labels Nov 1, 2019
@RobertZenz RobertZenz changed the title Location field tells me to enter a URL. Location field tells me to enter an URL. Nov 2, 2019
@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage labels Nov 12, 2019
@jancborchardt jancborchardt added the good first issue Good for newcomers label Jan 2, 2020
@jancborchardt
Copy link
Member

@RobertZenz can you describe exactly what would be expected? Then this would be a good first issue. :)

@skjnldsv
Copy link
Member

skjnldsv commented Jan 2, 2020

@jancborchardt the dav library understand location as an url, and this is forwarded to the html with an input[type=url].
We need this as a text, but weshould also add a plugin where you can autocomplete locations/pick on map

@jancborchardt jancborchardt removed the good first issue Good for newcomers label Jan 5, 2020
@spoorun
Copy link

spoorun commented Jan 5, 2020

Note, a similar scenario occurs with RELATED field (bug 1395) where the RFC requires either a URL or a declared text, but Nextcloud only likes a URL, with no picker.

@hanzi
Copy link
Member

hanzi commented Jan 18, 2020

To be clear: the RFC actually requires some kind of URI scheme here, see section 6.5.2. So this requirement is not actually wrong.

But I agree that there should be a more helpful and user-friendly widget for editing this property. Does anyone know how this property is actually being used in other clients?

@skjnldsv skjnldsv added this to the next minor milestone Sep 7, 2020
@ChristophWurst ChristophWurst removed this from the next minor milestone Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants