Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Following a /f/ link to a vcard file directly imports it? #2505

Closed
nickvergessen opened this issue Nov 10, 2021 · 5 comments
Closed

Following a /f/ link to a vcard file directly imports it? #2505

nickvergessen opened this issue Nov 10, 2021 · 5 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request feature: contacts

Comments

@nickvergessen
Copy link
Member

Describe the bug

Just happened to @szaimen and me

Contacts are automatically imported (or attempted to be imported)

To Reproduce
Steps to reproduce the behavior:

  1. Share a vcard/vcf in talk, it shows like this:
    Bildschirmfoto von 2021-11-10 16-58-05
  2. When you click on the entry, Talk redirects the user to the files app:
    https://…/f/4528…

Expected behavior
You see the file in the files app or something like that

Actual behavior
You see a "import finished" dialog:
Bildschirmfoto von 2021-11-10 17-01-56
Luckily it errored, but it is totally not intended to me that a f/ link to a vcf would directly import a contact to a "random" addressbook.

Server configuration

c.nc.

@szaimen
Copy link
Contributor

szaimen commented Nov 10, 2021

I think this was done in a recent enhancement PR but maybe instead of directly importing it, it would be great if you would have the possibility to first select the contact book and then click on a button to start the import...

@szaimen szaimen added enhancement New feature or request and removed bug Something isn't working labels Nov 10, 2021
@miaulalala
Copy link
Contributor

@szaimen do you have a link to the PR that you suspect introduced this behaviour?

@szaimen
Copy link
Contributor

szaimen commented Nov 11, 2021

I think it was probably this one: #1688

@skjnldsv skjnldsv added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage labels Nov 11, 2021
@skjnldsv
Copy link
Member

And have a confirmation: "This will import XXX contacts into the XX addressbook, proceed ?"

@joshtrichards
Copy link
Member

Duplicate of #2788

@joshtrichards joshtrichards marked this as a duplicate of #2788 Jan 15, 2024
@joshtrichards joshtrichards closed this as not planned Won't fix, can't repro, duplicate, stale Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request feature: contacts
Projects
None yet
Development

No branches or pull requests

5 participants