FN field behaviour: first and last name

[jonatoni]

When you try to add a new contact and you want to edit the name field there it's written by default "New contact" and you need to delete it in order to write the name of your contact.

Expected behaviour

Name field should be empty, in order to write the name of your contact.

Actual behaviour

At the field by default it is written "new contact" and to fill it you need to delete what is previously written there.

Server configuration

Contacts version: 1.5.4

[rutujasurve94]

I would like to take this bug up as a part of beginner level bug for Rails Girls Summer of Code 2018

[skjnldsv]

@rutujasurve94 please do! :)
You can create a pr to fix this issue. and we'll review it!

[rutujasurve94]

Hi! @skjnldsv @jancborchardt I tried to look up the file in the contacts repo where "New Contact" is put as the default value for the FN field. But, a grep search didn't return any file. The fn field has been defined in the dav.js and contact.js file. Could you hint as to which file we could look up for finding this default behaviour so that we can convert this string to NULL to fix this issue?

[skjnldsv]

You can't really set the FN field to null by default since a FN property is required by the vcard rfc :)
That's why there is a text by default, so the FN field isn't empty on creation.

Nonetheless, everything happens here: https://github.com/nextcloud/contacts/blob/master/js/services/contact_service.js#L226

[rutujasurve94]

I have raised a pull request here: #488
@skjnldsv @jancborchardt