Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact v5.3.0 does not present custom "group properties" in the new UI #3447

Open
mneiger opened this issue Jun 8, 2023 · 5 comments
Open
Labels
0. Needs triage bug Something isn't working feature: contacts regression Regression of a previous working feature

Comments

@mneiger
Copy link

mneiger commented Jun 8, 2023

Describe the bug

group properties as defined in vacrd RFCs v3 used to be viewable and editable in the old UI.
Now they are neither visible nor editable.

Steps to reproduce

import a vcf similar to

BEGIN:VCARD
VERSION:3.0
UID:rakefet-0c992
ADR;TYPE=HOME:;;Avenue de l'AAA;Bruxelles;;1180;Belgium
BDAY;VALUE=DATE:19540321
EMAIL;TYPE=HOME:cxxxxxxxxk@hotmail.com
FN:Cécile Maaaak
GENDER:F
N:Maaaak;Cécile;;;
RAK1.NICKNAME:Asher
RAK2.NOTE:archivé sept 2014
RAKR.RELATED;TYPE=SPOUSE;VALUE=TEXT:Julian Serais
REV;VALUE=DATE-AND-OR-TIME:20230311T095516Z
TEL;TYPE=CELL:+32 48 010101001
RAK1.X-ABLABEL:Hebrew
RAK2.X-ABLABEL:Rak-Note Fam
END:VCARD

Expected behavior

the properties grouped as RAKxx. (RAK1, RAK2 RAKR for nickname note and related) used to be displayed and usable as supplemental fields.

it is true that such group fields are application specific and could be ignored, according to the RFC. Theses specific group properties and contact are created by an external app, but it is critical for us to be able to see these fields in nextcloud and this used to work well in the previous contact app.

Perhaps a list or regex of group could be explicitely specified in order to be allowed in nextcloud contact app. This would allow to respect the new default behaviour and avoid messing with custom data.

Actual behavior

the said fields are invisible in the UI

Contact version

5.3.0

Operating system

Mint 21.1

PHP engine version

PHP 8.1.2

Web server

Nginx

Database

MariaDB

Additional info

No response

@FreePlague
Copy link

I've been adding custom types for phone numbers (instead default Home, Mobile, Work etc) for a long time and
after upgrading to Contacts 5.3.0 I've noticed:

  • Phones with custom types neither shown nor editable
  • After creating new phone with custom type it is created with default type Home
  • After looking at the vcf file, it looks like Nextcloud's approach to storing these types has changed several times, as a result, support was completely gone

NEXTCLOUD3.GROUP4TEL:phone number
GROUP1.X-ABLABEL:some text
GROUP2.X-ABLABEL:some text
GROUP3.X-ABLABEL:some text
GROUP4.X-ABLABEL:some text
NEXTCLOUD1.X-ABLABEL:some text
NEXTCLOUD2.X-ABLABEL:some text
NEXTCLOUD3.X-ABLABEL:some text
NEXTCLOUD7.X-ABLABEL:some text
NEXTCLOUD8.X-ABLABEL:some text
NEXTCLOUD9.X-ABLABEL:some text
NEXTCLOUD10.X-ABLABEL:some text
NEXTCLOUD11.X-ABLABEL:some text
NEXTCLOUD12.X-ABLABEL:some text
TEL;TYPE=CELL:phone number
TEL;TYPE=CELL:phone number
TEL;TYPE=CELL:phone number
NEXTCLOUD7.TEL;TYPE=HOME,VOICE:phone number
NEXTCLOUD8.TEL;TYPE=HOME,VOICE:phone number
NEXTCLOUD9.TEL;TYPE=HOME,VOICE:phone number
TEL;TYPE=CELL:phone number
TEL;TYPE=CELL:phone number
NEXTCLOUD10.TEL;TYPE=HOME,VOICE:phone number
NEXTCLOUD11.TEL;TYPE=HOME,VOICE:phone number
NEXTCLOUD12.TEL;TYPE=HOME,VOICE:phone number
TEL;TYPE=HOME,VOICE:phone number

This is related #3440

@tomasz-lasko
Copy link

I have the same effect as reported originally in #1842:
custom phone types when added on the phone, after sync do not show on nextcloud in contacts 5.3.2 but they do work OK on nextcloud in contacts 4.2.5

@NotSoFunnyClown
Copy link

Any fix for that? UI is not really usable if editing contacts on e.g. an iPhone. They just disappear in the contacts UI

@FreePlague
Copy link

Half-fix in 5.5.0. The old ones are displayed, but new ones cannot be created.

@FreePlague
Copy link

Regression in 6.1.0 (maybe earlier). Nextcloud 30.0.1
Custom phone labels not displaying anymore. Contacts still have old labels created before (can see it in exported vcf).
Maybe related #4188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage bug Something isn't working feature: contacts regression Regression of a previous working feature
Projects
None yet
Development

No branches or pull requests

5 participants