Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"index.php/apps" links are not working #802

Closed
weeman1337 opened this issue Dec 29, 2018 · 5 comments
Closed

"index.php/apps" links are not working #802

weeman1337 opened this issue Dec 29, 2018 · 5 comments
Labels
3. to review Waiting for reviews bug Something isn't working
Milestone

Comments

@weeman1337
Copy link
Member

weeman1337 commented Dec 29, 2018

Describe the bug

Links using the index.php/ schema are not working for the contacts app.
It works on the same system for other URLs like, files app or settings.

Closes nextcloud/server/issues/13265

To Reproduce
Steps to reproduce the behavior:

  1. Open any contact
  2. Modify the path and put index.php to the front
    e.g. https://nc.local/apps/contacts#/contact/a8e331ef-944d-4906-a9b2-5c696bcd9d63
    https://nc.local/index.php/apps/contacts#/contact/a8e331ef-944d-4906-a9b2-5c696bcd9d63
  3. Open this URL

Expected behavior
The contact is displayed.

Actual behavior
Nothing displayed.

Screenshots
image


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@weeman1337 weeman1337 added the bug Something isn't working label Dec 29, 2018
@weeman1337 weeman1337 changed the title "index.php/apps" links are not supported "index.php/apps" links are not working Dec 29, 2018
@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #717 (Added external link support), #414 (Browser Support), #679 (Full CLI Support), #251 (Phonetic name support), and #608 (Org vcard support).

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Dec 31, 2018
@skjnldsv skjnldsv added this to the 3.0.2 milestone Dec 31, 2018
@skjnldsv skjnldsv added the needs info Not enough information provided label Jan 4, 2019
@skjnldsv
Copy link
Member

skjnldsv commented Jan 4, 2019

@weeman1337 I'm having issues understanding this.
We're using the OC.generateURL function which automatically prepend the index.php if oc_config.modRewriteWorking is set to false. Can you access it without index.php?

@skjnldsv skjnldsv removed the 1. to develop Accepted and waiting to be taken care of label Jan 5, 2019
@skjnldsv
Copy link
Member

@weeman1337 bump?

@weeman1337
Copy link
Member Author

@skjnldsv sorry, I missed the previous notification.

Yes, it works without index.php. It doesn't if you add it. Have a look at the original issue, reported in the server repo. There the API is called including the index.php.

The question is: should it work in both cases: with and without index.php?

If yes: then there should be a fix here
no: the link generation from the original issue should be fixed. Then close this one here please.

@skjnldsv
Copy link
Member

The question is: should it work in both cases: with and without index.php?

No, is index.php is supported the server is designed to be used without it. At least the url generation algorithm we used is working like that :)
Though we should probably add a redirect on contacts then 🤔

@skjnldsv skjnldsv modified the milestones: 3.0.2, next Jan 21, 2019
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed needs info Not enough information provided labels Feb 1, 2019
@skjnldsv skjnldsv modified the milestones: next, 3.0.4 Mar 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants