Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a contact results in two PUT requests with same content #804

Closed
raimund-schluessler opened this issue Dec 30, 2018 · 2 comments
Closed
Labels
3. to review Waiting for reviews bug Something isn't working
Milestone

Comments

@raimund-schluessler
Copy link
Member

raimund-schluessler commented Dec 30, 2018

Describe the bug

When you create a new contact, you see two PUT requests with the same content. While this does not affect the functionality, I think the second request is not necessary.

To Reproduce
Steps to reproduce the behavior:

  1. Create a new contact.
  2. See two PUT requests and a PROPFIND.

This is because when a contact is created first line https://github.com/nextcloud/contacts/blob/master/src/store/contacts.js#L288 is called. Afterwards https://github.com/nextcloud/contacts/blob/master/src/store/contacts.js#L297 is called as well.

Contacts version: (see Nextcloud apps page)
Current master 8c4e9cb

@skjnldsv Is this a wanted behaviour? Did I miss something?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@nextcloud-bot
Copy link
Member

GitMate.io thinks possibly related issues are #294 (Create a read-only view of a contact), #285 (Cant create or save contacts), #189 (Group broken when creating new contact), #207 (Creating a contact in a group does not work), and #29 (Can't create new contacts on master).

@nextcloud-bot nextcloud-bot added the bug Something isn't working label Dec 30, 2018
@skjnldsv
Copy link
Member

@skjnldsv Is this a wanted behaviour? Did I miss something?

Most likely a sync that gets triggered. Should not happens indeed! :)
Thanks @raimund-schluessler 👍

@skjnldsv skjnldsv added the 1. to develop Accepted and waiting to be taken care of label Dec 31, 2018
@skjnldsv skjnldsv added this to the 3.0.2 milestone Dec 31, 2018
@skjnldsv skjnldsv modified the milestones: 3.0.2, next Jan 21, 2019
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Jan 31, 2019
@skjnldsv skjnldsv modified the milestones: next, 3.0.3 Feb 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants