-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Saving reverts changes which happened during the save. #923
Comments
Hello @RobertZenz :) Thanks for your report. I'm guessing you're on contacts 3.0.x? |
Exactly, 3.0.3 to be exact. |
@RobertZenz thanks. As you can see (I enabled bandwidth limiter), multiple save doesn't change the edits I do to the contact. |
I could not clearly see whether you were typing while the saving was in progress. Can I do something to debug this on my end? |
@RobertZenz I'll try with an even longer bandwidth multiplier. |
@RobertZenz Okay I was able to reproduce the issue just now! |
Glad to hear that you could reproduce it. Well, in my case it is not the bandwidth of the connection, it is my server directly. I'm using an oldish (10 years approaching Atom) as my main server, which is quite fast enough for the two users it needs to serve to. But from time to time it lacks a little. |
@skjnldsv How do I enable bandwidth limiter? I would like to test it with Tasks as well. |
@raimund-schluessler on the network tab of your dev tools, you can set various speed limits :) |
I dont know it this is related, but now everytime I try to edit a contact, it is never saved. The circle is constantly running indicating that it is saving, but it never gets saved. |
@JavierRSobrino anything in your browser's console? How to access your browser console (Click to expand)Chrome
Safari
IE9
Firefox
Opera
|
When editing a contact the contact is being automatically saved when you stop typing. Any changes you make during the saving process (the spinner is visible in the right upper corner) are being reverted the moment saving is completed.
This is especially bad when you, for example, type in a phone number while reading it from a different source. You start typing, then look at the source and this pause causes the save, so there's a chance that you'll start typing during the save and any input you've done during the saving process will be reverted, potentially leaving you with a partially filled in field.
Steps to reproduce the behavior
When saving finishes, everything you've typed during the saving will be reverted.
Expected behavior
Changes the user put into the field should never be silently reverted.
Actual behavior
They are silently reverted when the save finishes.
Note
It for sure is my server who is not as fast as a server could be, but this hasn't been a problem until the upgrade to 15.
The text was updated successfully, but these errors were encountered: