Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate scrollbar for ingredients list and cooking steps #1240

Open
TheMBeat opened this issue Oct 4, 2022 · 7 comments
Open

Separate scrollbar for ingredients list and cooking steps #1240

TheMBeat opened this issue Oct 4, 2022 · 7 comments
Labels
dependent enhancement New feature or request Frontend Issue or PR related to the frontend code

Comments

@TheMBeat
Copy link
Contributor

TheMBeat commented Oct 4, 2022

Is your feature request related to a problem? Please describe.
On the IPad in portait mode, the ingredient lists are above the individual cooking steps. Here it would be nice if the lists were also side by side.
When the IPad is horizontal, both lists are next to each other, but they cannot be scrolled independently. This means you always have to scroll up to look at the ingredients again.

Describe the solution you'd like
Serperate scrollbar for ingredients list and cooking steps


Depends on #1244

@TheMBeat TheMBeat added the enhancement New feature or request label Oct 4, 2022
@Benedikt81
Copy link

Hi, for those who don't have an ipad: Can you add screenshots?

@christianlupus
Copy link
Collaborator

More importantly: what are the sizes in px?

I do not get the exact idea you seem to have. Let's separate concerns.

For landscape mode, the list is aligned to the side. You would like to have separate scroll bars for the ingredients and the rest of the recipe. Correct so far?
I think it makes sense to reorder the tools then as well. You need them prepared before beginning, so putting them above the instructions might be a good idea while allowing scrolling to any position in the instructions and having the ingredients visible at the same time.

Not for the portrait mode. What is the effective width in pixel of the browser?
Can you describe it better even create a sketch of how the screen should be split? Please be as concrete as possible as i do not see a intuitive way of organizing things ATM.

Thank you

@christianlupus christianlupus added Frontend Issue or PR related to the frontend code stalebot-enabled The PR/issue is marked to go stale over time labels Oct 13, 2022
@MarcelRobitaille MarcelRobitaille changed the title Serperate scrollbar for ingredients list and cooking steps Separate scrollbar for ingredients list and cooking steps Oct 14, 2022
@github-actions
Copy link

This issue was not updated for 45 days. It is therefore marked as stale. When no update occurs within the next 7 days, this issue will be closed automatically in the next 7 days.

@github-actions github-actions bot added the stale The PR/issue is marked as stale label Nov 29, 2022
@TheMBeat
Copy link
Contributor Author

TheMBeat commented Dec 1, 2022

image
image

@TheMBeat
Copy link
Contributor Author

TheMBeat commented Dec 1, 2022

Here we can get all
Display Size

In the first Screenshot the yellow stroke should be Scrollbars

@github-actions github-actions bot removed the stale The PR/issue is marked as stale label Dec 2, 2022
@christianlupus
Copy link
Collaborator

I will postpone this issue until the new UI is implemented. Then, we can revaluate this issue here if it will be still valid.

@christianlupus christianlupus removed the stalebot-enabled The PR/issue is marked to go stale over time label Dec 5, 2022
@github-actions
Copy link

github-actions bot commented Dec 5, 2022

This PR/issue depends on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependent enhancement New feature or request Frontend Issue or PR related to the frontend code
Projects
Status: To do
Development

No branches or pull requests

3 participants