Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harden the database queries #14

Closed
christianlupus opened this issue Jul 12, 2019 · 3 comments
Closed

Harden the database queries #14

christianlupus opened this issue Jul 12, 2019 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@christianlupus
Copy link
Collaborator

At the moment, the database entries seem not be quoted as far as I understand. So a normal user might use e.g. the search fields to do some SQL injection.

I saw this in when working on PR #12 for #5. Maybe I will find some time for a small PR but I wanted to keep this documented that there is a security vulerability.
@mrzapp
Copy link
Contributor

mrzapp commented Jul 12, 2019

@christianlupus You may be right about that. Luckily, only the findRecipes method should be affected, so a small change to that should take care of it.

I'm no expert on SQL injection myself, so your contribution would be highly appreciated! 🙏

@mrzapp mrzapp added the enhancement New feature or request label Jul 25, 2019
@mrzapp mrzapp added the good first issue Good for newcomers label Aug 8, 2019
@christianlupus
Copy link
Collaborator Author

I just added the PR #25 for this issue.

@mrzapp
Copy link
Contributor

mrzapp commented Aug 8, 2019

@christianlupus great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrzapp @christianlupus