Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searchbox autoenable #176

Closed
pixelipo opened this issue Jun 9, 2017 · 2 comments
Closed

Searchbox autoenable #176

pixelipo opened this issue Jun 9, 2017 · 2 comments

Comments

@pixelipo
Copy link
Contributor

pixelipo commented Jun 9, 2017

It seems that we are using a hack to show force display #searchbox:
https://github.com/nextcloud/deck/blob/master/css/style.css#L57

From what I could tell, this tag is hidden by hasFilter in core search.js:
https://github.com/nextcloud/server/blob/master/core/search/js/search.js#L383

Mail app is defining this method:

setUpSearch: function() {
	SearchProxy.setFilter(require('search').filter);
}

which seems to do the trick.

I'm not too familiar with Deck's JS just yet to figure out where to implement this. @juliushaertl could you give me some hints?


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@juliusknorr
Copy link
Member

Not entirely sure, but i think https://github.com/nextcloud/deck/blob/master/js/directive/search.js is the right place. 😉

@juliusknorr juliusknorr added this to the 0.3.0 milestone Nov 13, 2017
@juliusknorr juliusknorr modified the milestones: 0.3.0, Backlog Dec 5, 2017
@juliusknorr juliusknorr removed this from the Backlog milestone Oct 25, 2018
@juliusknorr
Copy link
Member

Fixed with the new search standard.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants