Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autosave a card description on page reload #2174

Open
matchish opened this issue Aug 7, 2020 · 7 comments
Open

Autosave a card description on page reload #2174

matchish opened this issue Aug 7, 2020 · 7 comments

Comments

@matchish
Copy link
Contributor

matchish commented Aug 7, 2020

Describe the bug
When you edit a card and then without pause reload the page the modifications are lost

Expected behavior
The card description have to be saved before page reload

Server details

Nextcloud version: 18.0.4

List of activated apps:

Enabled:

  • accessibility: 1.4.0
  • bruteforcesettings: 1.5.0
  • calendar: 2.0.2
  • cloud_federation_api: 1.1.0
  • comments: 1.8.0
  • contacts: 3.2.0
  • dav: 1.14.0
  • deck: 1.0.5
  • federatedfilesharing: 1.8.0
  • federation: 1.8.0
  • files: 1.13.1
  • files_sharing: 1.10.1
  • files_trashbin: 1.8.0
  • files_versions: 1.11.0
  • logreader: 2.3.0
  • lookup_server_connector: 1.6.0
  • mail: 1.1.3
  • oauth2: 1.6.0
  • onlyoffice: 4.1.4
  • password_policy: 1.9.0
  • provisioning_api: 1.8.0
  • settings: 1.0.0
  • sharebymail: 1.8.0
  • spreed: 8.0.8
  • systemtags: 1.8.0
  • theming: 1.9.0
  • twofactor_backupcodes: 1.7.0
  • updatenotification: 1.8.0
  • workflowengine: 2.0.0
    Disabled:
  • admin_audit
  • defaultgroup
  • encryption
  • files_external
  • occweb
  • testing
  • user_ldap
@stefan-niedermann
Copy link
Member

stefan-niedermann commented Aug 10, 2020

One could use localStorage or sessionStorage.

I would prefer the latter for security and privacy reasons (in case of multiple people using thr same device).

@matchish do you want to provide a Pull Request? 🚀 🙂


This approach might also be used to the comments field.

@juliusknorr
Copy link
Member

Browsers are quite limiting on actions that can be performed if a page is closed or reloaded, so the only thing we could do here is probably to block navigating away with an confirmation dialog.

@jakobroehrl
Copy link
Contributor

@juliushaertl Could you give me a hint how to recognize a page close/reload?

@juliusknorr
Copy link
Member

@reox
Copy link
Contributor

reox commented Jul 3, 2023

Another thing I noticed today is, that if you have the edit dialog open (modal or sidebar, does not matter), paste some text into the description and click anywhere else than the edit dialog (such that the modal/sidebar closes), the content is lost.
I would appreciate a "save on exit" in those instances!

@Akselmo
Copy link

Akselmo commented Dec 11, 2023

Been having this same issue. I wouldn't mind having somekind of force-save button or whatever.

The only way to get descriptions save for me is to:

  1. type description
  2. click outside of description
  3. edit the title
  4. save title

Also sometimes editing description twice works. But it's very unreliable.

@fferri
Copy link

fferri commented Feb 29, 2024

I have similar issues, where the automatic saving of the description field is not always triggered (or it doesn't always succeed). See #5628.

While it is not easy to track down all possible ways of losing the entered information, one simple check it should be done when navigating away, but also when simply closing the card edit window, so that if save didn't happen, prevent any further action that would cause loss of entered data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants