Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: open card with direct link #5089

Closed
wants to merge 1 commit into from

Conversation

luka-nextcloud
Copy link
Contributor

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@cypress
Copy link

cypress bot commented Sep 4, 2023

Passing run #1450 ↗︎

0 17 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 3ee2c0731f2eb08cbdc72b0d6525755708bdf455 into ae81baf...
Project: Deck Commit: 2b11fe73c5 ℹ️
Status: Passed Duration: 01:38 💡
Started: Sep 19, 2023 5:01 AM Ended: Sep 19, 2023 5:03 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

src/components/card/CardSidebar.vue Outdated Show resolved Hide resolved
@luka-nextcloud luka-nextcloud force-pushed the bugfix/open-card-by-link-issue branch from 2fe9763 to 3ee2c07 Compare September 19, 2023 04:57
@luka-nextcloud
Copy link
Contributor Author

@max-nextcloud Could you please review? Thanks.

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr juliusknorr force-pushed the bugfix/open-card-by-link-issue branch from 3ee2c07 to 3b92f27 Compare October 17, 2023 20:31
@juliusknorr
Copy link
Member

@luka-nextcloud I fail to reproduce the issue this is supposed to fix. I would expect the previous code to already work as expected. Can you tell if you can still see this issue on the main branch and maybe provide some detailed steps you take to reproduce?

@luka-nextcloud
Copy link
Contributor Author

@luka-nextcloud I fail to reproduce the issue this is supposed to fix. I would expect the previous code to already work as expected. Can you tell if you can still see this issue on the main branch and maybe provide some detailed steps you take to reproduce?

Hmm, I just tested again on the latest branch and couldn't reproduce the problem.

@juliusknorr
Copy link
Member

Maybe it is just something on stable27/stable26 ...

@luka-nextcloud
Copy link
Contributor Author

Maybe it is just something on stable27/stable26 ...

I've tested on them, I cannot reproduce.

@juliusknorr
Copy link
Member

Let's close this then for now. We can reconsider the fix if we manage to reproduce or run into this again somehow.

@juliusknorr juliusknorr closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Card edit modal does not show up when access from direct url
2 participants