Activity notification emails don't contain user and other details

[putt1ck]

If you enable email notification for Deck, the notification emails don't identify the user who carried out the action, nor the action e.g.

Today at 08:21
has created in Notes on_

The user and action are correctly identified in the same item in the activity stream e.g.

John Doe has created My example note in Notes on

To Reproduce
Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Client details:

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]
• Device: [e.g. iPhone6, desktop]

Server details

Operating system:

Web server:

Database:

PHP version:

Nextcloud version: (see Nextcloud admin page)

Where did you install Nextcloud from:

Signing status:

Login as admin user into your Nextcloud and access
http://example.com/index.php/settings/integrity/failed
paste the results here.

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your Nextcloud installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

or

Insert your config.php content here
Make sure to remove all sensitive content such as passwords. (e.g. database password, passwordsalt, secret, smtp password, …)

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...

Logs

Nextcloud log (data/nextcloud.log)

Insert your Nextcloud log here

Browser log

Insert your browser log here, this could for example include:

a) The javascript console log
b) The network log
c) ...

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[ashgoodman]

another example

In the activity stream it says:
John Doe has commented on Some card name 30 minutes ago

Comment content goes here

but in the email it says
Today at 4:10 PM
has commented on

So the email is missing context (what card), who, and what was said

[putt1ck]

Deck 0.61 on NC15
Received email of form

{user} has updated the description of the card CardName in stack StackName on board BoardName.

where the activity stream for the card (and general) has

UserName has updated the description of the card CardName in stack StackName on board BoardName

Looking at an older email with more activity to report, the failure to include the username is inconsistent (same user/board/stack and even card) and is sometimes included and sometimes not.

NB this is the only activity I'm currently opting for emails on (any NC instance) so cannot tell if it's Deck specific or not. Same bug?

[Nils160988]

Can confirm this behavior, is deck specific (other notifications are ok).

[rubo77]

I also got this email message today (exactly like this, with curly brackets):

Es gab Aktivitäten bei myExample cloud
Heute um 09:13
Rich subject or a parameter for "{user} has updated the description of
the card {card} in list {stack} on board {board}" is malformed

It seems like there is some replacement missing.

also reported here: #1755

[rubo77]

see #1254 (comment)

This is definitely a activity issue !
See :
https://github.com/nextcloud/activity/blob/2c6ec88c465ff79342b6c5ffbce03625f10f08e4/lib/Data.php#L124

There is no check when doing the insert into activity_mq

can we close this as duplicate?