-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split name and descripton of activities in main dialog #3665
Comments
Let's have a call to discuss what you need and how we can achieve it. But string splitting is at least not a good idea (due to translations and other things) |
I'm subscribing to this enhancement report because, as I commented in #3703, the text does not fit the main dialog and is not legible. |
C&P: @jancborchardt still something we want to do? |
@tobiasKaminsky yes, absolutely! :) This will allow us to be more compact and concise in notifications rather than showing a whole unwieldy sentence. (Also ref the mockups for the Talk notifications by @nimishavijay at #5275 ) |
There is a bit of a technical difference. The talk notifications have a subject and message and basically the client can simply overwrite the subject with the username and show the message without touching. The thing you suggest here is splitting a single string into multiple, which will not work due to translations. A translation neutral subject is not available on the client level so they would not know what kind of string to use:
is xyz changed, or shared, or created, or deleted, ... You can not know it because the translation does not give it away. |
Having a new version of this endpoint, which gives those information, translated on server, should be possible?
Something similar should also be possible for multiple files. Then clients can use new / old endpoint depending on NC major version. |
Well that also requires breaking the PHP API for all apps that provide activities, so really not a fan. But on that note, it seems like the message/subline (apart from broken casing, I think the screenshot should start with upper case?) is the "short subject" we use in the right sidebar: So a random idea would be to: When long/normal version is requested and the user agent is our desktop client, we return the short subject as message and the file as subject? |
If there is a full list of all the types of activities + the primary and or secondary actions for them @jancborchardt and I can make mockups for it :) |
There is not, any app can invent a new activity at any time |
"hiding" this logic bound to UA is strange. @jancborchardt I understood that you want to change this on all (web and all clients?) |
How to use GitHub
Feature description
Move from a sentence for an activity to the splitting of name, action, etc → probably needs changes in the API and coordination with @nickvergessen
Context and screenshots: #3644
The text was updated successfully, but these errors were encountered: