Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split name and descripton of activities in main dialog #3665

Closed
FlexW opened this issue Aug 12, 2021 · 10 comments
Closed

Split name and descripton of activities in main dialog #3665

FlexW opened this issue Aug 12, 2021 · 10 comments
Labels
confirmed bug approved by the team enhancement enhancement of a already implemented feature/code

Comments

@FlexW
Copy link

FlexW commented Aug 12, 2021

How to use GitHub

  • Please use the 👍 reaction to show that you want to have the same feature implemented.
  • Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
  • Subscribe to receive notifications on status change and new comments.

Feature description

Move from a sentence for an activity to the splitting of name, action, etc → probably needs changes in the API and coordination with @nickvergessen

Context and screenshots: #3644

@FlexW FlexW added enhancement enhancement of a already implemented feature/code confirmed bug approved by the team labels Aug 12, 2021
@nickvergessen
Copy link
Member

Let's have a call to discuss what you need and how we can achieve it. But string splitting is at least not a good idea (due to translations and other things)

@wonx
Copy link

wonx commented Oct 20, 2021

I'm subscribing to this enhancement report because, as I commented in #3703, the text does not fit the main dialog and is not legible.

@tobiasKaminsky tobiasKaminsky moved this to 🧭 Planning evaluation (dont pick) in 🤖 🍏 Clients team Aug 18, 2022
@tobiasKaminsky
Copy link
Member

C&P:
Move from a sentence for an activity to the splitting of name, action, etc.

image

@jancborchardt still something we want to do?

@jancborchardt
Copy link
Member

@tobiasKaminsky yes, absolutely! :) This will allow us to be more compact and concise in notifications rather than showing a whole unwieldy sentence.

(Also ref the mockups for the Talk notifications by @nimishavijay at #5275 )

@nickvergessen
Copy link
Member

nickvergessen commented Feb 22, 2023

There is a bit of a technical difference. The talk notifications have a subject and message and basically the client can simply overwrite the subject with the username and show the message without touching.

The thing you suggest here is splitting a single string into multiple, which will not work due to translations. A translation neutral subject is not available on the client level so they would not know what kind of string to use:

  • UserA xyzed FileA

is xyz changed, or shared, or created, or deleted, ... You can not know it because the translation does not give it away.

@tobiasKaminsky
Copy link
Member

image

Having a new version of this endpoint, which gives those information, translated on server, should be possible?
API could return

  • icon
  • user who is doing something (M)
  • title
  • subline
  • date
  • location

Something similar should also be possible for multiple files.

Then clients can use new / old endpoint depending on NC major version.

@nickvergessen
Copy link
Member

nickvergessen commented Feb 22, 2023

Well that also requires breaking the PHP API for all apps that provide activities, so really not a fan.

But on that note, it seems like the message/subline (apart from broken casing, I think the screenshot should start with upper case?) is the "short subject" we use in the right sidebar:
https://github.com/nextcloud/server/blob/ccd08877e803be1281b6c9325219e862c1995f9c/apps/files_sharing/lib/Activity/Providers/Users.php#L53-L75

So a random idea would be to: When long/normal version is requested and the user agent is our desktop client, we return the short subject as message and the file as subject?
Sample PR which adjusted user shares available at nextcloud/server#36804

grafik

@nimishavijay
Copy link
Member

If there is a full list of all the types of activities + the primary and or secondary actions for them @jancborchardt and I can make mockups for it :)

@nickvergessen
Copy link
Member

If there is a full list of all the types of activities + the primary and or secondary actions

There is not, any app can invent a new activity at any time

@tobiasKaminsky
Copy link
Member

So a random idea would be to: When long/normal version is requested and the user agent is our desktop client, we return the short subject as message and the file as subject?

"hiding" this logic bound to UA is strange.
Then better have this as an explicit and optional parameter.

@jancborchardt I understood that you want to change this on all (web and all clients?)

@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation (don't pick) to ☑️ Done in 🤖 🍏 Clients team Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed bug approved by the team enhancement enhancement of a already implemented feature/code
Projects
Status: ☑️ Done
Development

No branches or pull requests

7 participants