Release 3.4.1

[mgallien]

📝 TO DO

• ⬆️ Bump VERSION.cmake to 3.4.1 and doc/conf.py (release to 3.4.1) in the corresponding stable branch
• 🏷️ Create tag from corresponding stable branch on the commit introducing the version bump

$ git checkout stable-3.4
$ git pull
$ git tag -s -m "Release 3.4.1" v3.4.1 
$ git push origin --tags

• 🏷️ Create tag from corresponding stable branch in client-building. Steps to create the tag are the same as the above.
• 🏭 Trigger the builds on brander and wait for them to succeed:
  • 🐧 Linux
  • 🍎 Mac OS
  • 🚪 Windows MSI
• 🧪 Execute the bugfix release test plan for each build:
  • 🐧 Linux
  • 🍎 Mac OS
  • 🚪 Windows MSI
• 📖 Get changelog using github_helper scripts, with previous 3.4 release as origin point
• 📖 Create draft pre-release at:
  • nextcloud/desktop/releases with the changelog
  • nextcloud-releases/desktop/releases
• 📦 Upload binaries to:
  • the draft pre-release at nextcloud/desktop/releases
  • the draft pre-release at nextcloud-releases/desktop/releases
  • download.nextcloud.com in the user home directory (so still private)
• 🗝️ Sign binaries (ssh -P 2200 to signing VM, then, cat how-to-sign, then scp -P 2200 to download signatures)
• 🛎️ Notify Marketing that the release is ready
• 🚀 When marketing gives the go then publish the draft pre-releases created previously at:
  • nextcloud/desktop/releases
  • nextcloud-releases/desktop/releases
  • run the publish_desktop.sh script on download.nextcloud.com so that the binaries appear at download.nextcloud.com/desktop/releases
• 🆙 Change the updater server config to serve the release
• 🆙 Change the install-clients config to update the link to the latest release on Nextcloud website

[PhilippSchlesinger]

Will this release clean up server side mtime problems on files affected by #4016 via restoring previous file versions?

[allexzander]

Will this release clean up server side mtime problems on files affected by #4016 via restoring previous file versions?

@PhilippSchlesinger
Sorry, but, files affected needs to be fixed manually https://github.com/nextcloud/desktop/wiki/Fix-bug-invalid-modification-date

Uploading files with incorrect mtime is fixed in this client version.

[janseta]

Hi, @PhilippSchlesinger

this script is for MySQL database but I (and meny people) use Nexcloud inside Syncloud, and so we use Postgres database instead of MySQL database

Could you so kind to fix this script (or tell us the changes needed) ?
(My linux and database knolenge is very poor, so I'm not able, but I have 300 Gb of broken files now because of this issue...)

[ofsahin]

i also use nextcloud and when i try to run the script i got permission error. after searching for a while i found out that it is because my nextcloud folder is mounted with noexec option on docker. tried mount /config -o remount,exec but it doesn't work. is there any other way this could be fixed? perhaps with a php script? it would work for other db's as well?

[Derkades]

i also use nextcloud and when i try to run the script i got permission error. after searching for a while i found out that it is because my nextcloud folder is mounted with noexec option on docker. tried mount /config -o remount,exec but it doesn't work. is there any other way this could be fixed? perhaps with a php script? it would work for other db's as well?

Easy solution: run bash script.sh instead of ./script.sh. Alternatively, tweak your docker volume settings instead of trying to remount while the container is running.

[ofsahin]

not that easy, already tried bash /config/www/nextcloud/solvable_files.sh or inside the dir and bash solvable_files.sh
i get

find: unrecognized: -newermt
BusyBox v1.33.1 () multi-call binary.

i use linuxserver io's nextcloud image on alpine

also couldn't find anything on docker docs or google on how to mount without noexec option and instead with exec option. i spent almost a good hour.

[ofsahin]

in case anyone else encounters the same problem

i updated findutils to get newermt functionality and mysql on my nextcloud container

apk add --update findutils
apk add --update mysql mysql-client

and ran the code like this:
bash /config/www/nextcloud/solvable_files.sh /data <db_host> <db_user> <db_pwd> <db_name> abc fix
solvable_files.sh <data_dir> <db_host> <db_user> <db_pwd> <db_table> <web_user> <fix,list>

[lucrito]

What worked for me, without running anything server side (I use docker and running the fix script would have involved some debugging / research I was not willing to invest time in):
I had the Problem on two Win 10 clients after the automatic update from Nextcloud to version 3.4.0.

After a brief dig in the internet, I found this thread and tried the script, with the above mentioned result of my laziness ;)

Then I went back to client version 3.3.6 and waited for all syncs to become green.

Then I updated to client version 3.4.2. It would probably also work with 3.4.1.

So far no problems.

[jfabaf]

in case anyone else encounters the same problem

i updated findutils to get newermt functionality and mysql on my nextcloud container

apk add --update findutils
apk add --update mysql mysql-client

and ran the code like this: bash /config/www/nextcloud/solvable_files.sh /data <db_host> <db_user> <db_pwd> <db_name> abc fix solvable_files.sh <data_dir> <db_host> <db_user> <db_pwd> <db_table> <web_user> <fix,list>

Thank you very much.
Same issue here, I ran this to solve it into linusserver.io nextcloud docker container:

cd /config/www/nextcloud/
apk add --update findutils
apk add --update mysql mysql-client
wget https://raw.githubusercontent.com/nextcloud-gmbh/mtime_fixer_tool_kit/master/solvable_files.sh
chmod a+x solvable_files.sh

./solvable_files.sh /data mysql <dbhost> <dbuser> <dbpass> <dbname> list noscan

And, if list of files are ok:
./solvable_files.sh /data mysql <dbhost> <dbuser> <dbpass> <dbname> fix scan